From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id DA1273959C7E for ; Wed, 16 Nov 2022 10:50:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA1273959C7E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kam.mff.cuni.cz Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id C7218284AB7; Wed, 16 Nov 2022 11:49:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1668595797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdtUkekrUiW9l5G5BRsKQj7fAH/GZLWgkNzc0PkkIEY=; b=UpBtOB4nLTtcRE73aiNRc7vQUX53VW3F22ZNeFhYrqDgcip+mxQR5Zw6aUc01o2d31xTLc Ehjon+SvX0639coU4rJkGe3M0CA07edmYIzG4W6DHPVt3KeqgcrfAD2l62laTcK62hLEci xHm9N3hoWqIBtkqktz3oMKhDzaBqeL4= Date: Wed, 16 Nov 2022 11:49:57 +0100 From: Jan Hubicka To: Martin Jambor Cc: GCC Patches Subject: Re: [PATCH 01/12] ipa: IPA-SRA split detection simplification Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi, > > I have noticed that the flag m_split_modifications_p of > ipa_param_body_adjustments is not really necessary as it has to > correspond to whether m_replacements is non-empty so this patch > removes it. This also simplifies a bit some patches I work on. > > Bootstrapped and tested on x86_64-linux. OK for master? OK, thanks! Honza > > Thanks, > > Martin > > > gcc/ChangeLog: > > 2022-11-10 Martin Jambor > > * ipa-param-manipulation.cc > (ipa_param_body_adjustments::common_initialization): Do not set > m_split_modifications_p. > (ipa_param_body_adjustments::ipa_param_body_adjustments): Remove > initializations of m_split_modifications_p. > (ipa_param_body_adjustments::modify_call_stmt): Check that > m_replacements is empty instead of m_split_modifications_p. > --- > gcc/ipa-param-manipulation.cc | 29 +++++++++++++---------------- > gcc/ipa-param-manipulation.h | 4 ---- > 2 files changed, 13 insertions(+), 20 deletions(-) > > diff --git a/gcc/ipa-param-manipulation.cc b/gcc/ipa-param-manipulation.cc > index 23a8cb84d48..cee0e23f946 100644 > --- a/gcc/ipa-param-manipulation.cc > +++ b/gcc/ipa-param-manipulation.cc > @@ -1378,7 +1378,6 @@ ipa_param_body_adjustments::common_initialization (tree old_fndecl, > > if (apm->op == IPA_PARAM_OP_SPLIT) > { > - m_split_modifications_p = true; > split[prev_index] = true; > register_replacement (apm, new_parm); > } > @@ -1472,10 +1471,10 @@ ipa_param_body_adjustments > ::ipa_param_body_adjustments (vec *adj_params, > tree fndecl) > : m_adj_params (adj_params), m_adjustments (NULL), m_reset_debug_decls (), > - m_split_modifications_p (false), m_dead_stmts (), m_dead_ssas (), > - m_dead_ssa_debug_equiv (), m_dead_stmt_debug_equiv (), m_fndecl (fndecl), > - m_id (NULL), m_oparms (), m_new_decls (), m_new_types (), m_replacements (), > - m_removed_decls (), m_removed_map (), m_method2func (false) > + m_dead_stmts (), m_dead_ssas (), m_dead_ssa_debug_equiv (), > + m_dead_stmt_debug_equiv (), m_fndecl (fndecl), m_id (NULL), m_oparms (), > + m_new_decls (), m_new_types (), m_replacements (), m_removed_decls (), > + m_removed_map (), m_method2func (false) > { > common_initialization (fndecl, NULL, NULL); > } > @@ -1489,11 +1488,10 @@ ipa_param_body_adjustments > ::ipa_param_body_adjustments (ipa_param_adjustments *adjustments, > tree fndecl) > : m_adj_params (adjustments->m_adj_params), m_adjustments (adjustments), > - m_reset_debug_decls (), m_split_modifications_p (false), m_dead_stmts (), > - m_dead_ssas (), m_dead_ssa_debug_equiv (), m_dead_stmt_debug_equiv (), > - m_fndecl (fndecl), m_id (NULL), m_oparms (), m_new_decls (), > - m_new_types (), m_replacements (), m_removed_decls (), m_removed_map (), > - m_method2func (false) > + m_reset_debug_decls (), m_dead_stmts (), m_dead_ssas (), > + m_dead_ssa_debug_equiv (), m_dead_stmt_debug_equiv (), m_fndecl (fndecl), > + m_id (NULL), m_oparms (), m_new_decls (), m_new_types (), m_replacements (), > + m_removed_decls (), m_removed_map (), m_method2func (false) > { > common_initialization (fndecl, NULL, NULL); > } > @@ -1513,11 +1511,10 @@ ipa_param_body_adjustments > copy_body_data *id, tree *vars, > vec *tree_map) > : m_adj_params (adjustments->m_adj_params), m_adjustments (adjustments), > - m_reset_debug_decls (), m_split_modifications_p (false), m_dead_stmts (), > - m_dead_ssas (), m_dead_ssa_debug_equiv (), m_dead_stmt_debug_equiv (), > - m_fndecl (fndecl), m_id (id), m_oparms (), m_new_decls (), m_new_types (), > - m_replacements (), m_removed_decls (), m_removed_map (), > - m_method2func (false) > + m_reset_debug_decls (), m_dead_stmts (), m_dead_ssas (), > + m_dead_ssa_debug_equiv (), m_dead_stmt_debug_equiv (), m_fndecl (fndecl), > + m_id (id), m_oparms (), m_new_decls (), m_new_types (), m_replacements (), > + m_removed_decls (), m_removed_map (), m_method2func (false) > { > common_initialization (old_fndecl, vars, tree_map); > } > @@ -1979,7 +1976,7 @@ ipa_param_body_adjustments::modify_call_stmt (gcall **stmt_p, > && m_dead_ssas.contains (t)) > recreate = true; > > - if (!m_split_modifications_p) > + if (m_replacements.is_empty ()) > continue; > > tree base; > diff --git a/gcc/ipa-param-manipulation.h b/gcc/ipa-param-manipulation.h > index a9ad2b216be..e5654f4ff70 100644 > --- a/gcc/ipa-param-manipulation.h > +++ b/gcc/ipa-param-manipulation.h > @@ -350,10 +350,6 @@ public: > > auto_vec m_reset_debug_decls; > > - /* Set to true if there are any IPA_PARAM_OP_SPLIT adjustments among stored > - adjustments. */ > - bool m_split_modifications_p; > - > /* Sets of statements and SSA_NAMEs that only manipulate data from parameters > removed because they are not necessary. */ > hash_set m_dead_stmts; > -- > 2.38.0 >