public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 02/12] ipa-cp: Do not consider useless aggregate constants
Date: Wed, 16 Nov 2022 11:50:26 +0100	[thread overview]
Message-ID: <Y3TAchpA/M/dVEoy@kam.mff.cuni.cz> (raw)
In-Reply-To: <ri6tu35kksn.fsf@suse.cz>

> Hi,
> 
> When building vectors of known aggregate values, there is no point in
> including those for parameters which are not used in any way
> whatsoever.
> 
> Bootstrapped and tested on x86_64-linux.  OK for master?
OK,
thanks!
Honza
> 
> Thanks,
> 
> Martin
> 
> 
> gcc/ChangeLog:
> 
> 2022-11-11  Martin Jambor  <mjambor@suse.cz>
> 
> 	* ipa-cp.cc (push_agg_values_from_edge): Do not consider constants
> 	in unused aggregate parameters.
> ---
>  gcc/ipa-cp.cc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/ipa-cp.cc b/gcc/ipa-cp.cc
> index d2bcd5e5e69..02bd6a0fd1a 100644
> --- a/gcc/ipa-cp.cc
> +++ b/gcc/ipa-cp.cc
> @@ -5783,7 +5783,8 @@ push_agg_values_from_edge (struct cgraph_edge *cs,
>  	}
>  
>        ipcp_param_lattices *plats = ipa_get_parm_lattices (dest_info, index);
> -      if (plats->aggs_bottom)
> +      if (!ipa_is_param_used (dest_info, index)
> +	  || plats->aggs_bottom)
>  	continue;
>        push_agg_values_for_index_from_edge (cs, index, res, interim);
>      }
> -- 
> 2.38.0
> 

      parent reply	other threads:[~2022-11-16 10:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12  1:45 Martin Jambor
2022-11-13 21:06 ` Martin Jambor
2022-11-16 10:50 ` Jan Hubicka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3TAchpA/M/dVEoy@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).