From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C31893854547 for ; Fri, 18 Nov 2022 07:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C31893854547 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668757806; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=n4mKhbkSvcbRLEbsLQ7zH8x/Vy4+OpnpTWbvd4szYX4=; b=hPWLEt6NkjSrK7joa1XZqMJWw0nn9mriZ5vBvJC6aIYmn7g04+hDrIrns2qjodwaOn3Ls6 lQSSjoHdHHEoS3EgqiAFQ5nTPOx0RMynaO6sBhmSog2/7Vjvdy5atpuN5vUR4SQLUKztFe C6Asta8rFxc9K6JODF7k/SkH1yg8Agk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-444-V-6UHzf1P9yTL0lgdUNqKQ-1; Fri, 18 Nov 2022 02:50:03 -0500 X-MC-Unique: V-6UHzf1P9yTL0lgdUNqKQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBC34382F163; Fri, 18 Nov 2022 07:50:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D8DD2166B29; Fri, 18 Nov 2022 07:50:02 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2AI7nvsJ1888563 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Nov 2022 08:49:58 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2AI7nujw1888562; Fri, 18 Nov 2022 08:49:56 +0100 Date: Fri, 18 Nov 2022 08:49:56 +0100 From: Jakub Jelinek To: liuhongt Cc: gcc-patches@gcc.gnu.org, crazylht@gmail.com, hjl.tools@gmail.com, ubizjak@gmail.com Subject: Re: [PATCH] [x86] define builtins for "shared" avxneconvert-avx512bf16vl builtins. Message-ID: Reply-To: Jakub Jelinek References: <20221118014522.1989180-1-hongtao.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20221118014522.1989180-1-hongtao.liu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 18, 2022 at 09:45:22AM +0800, liuhongt via Gcc-patches wrote: > This should fix incorrect error when call those builtin with > -mavxneconvert and w/o -mavx512bf16 -mavx512vl. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,} > Ready to push to trunk. > > gcc/ChangeLog: > > * config/i386/i386-builtins.cc (def_builtin): Hanlde "shared" Just a nit: s/Hanlde/Handle/ > avx512bf16vl-avxneconvert builtins. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/avxneconvert-1.c: New test. Jakub