From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 69833384F4A4 for ; Mon, 21 Nov 2022 10:02:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69833384F4A4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669024946; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=EP863r2C9npGCTBhUCjuVjCYjc+pgHeqto19iZGP2EU=; b=QmX97zi3QTOfM5NhZ9UWLvZ9qMHqlcZKZ7NtldB8d/GSFMNfqneoxOLgKefC95zdMv75VG 406+1iPKlzHQ8h0H77VpcwSf48/IfZV3tf7KyQ8kuF770abKkvNZFWbZyWIQab3eRikIB9 bd7NSBqx90pO/lGLNAHVcRSSshTETYE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-375-OZBB4ZAFO-yxhw2k1sAcig-1; Mon, 21 Nov 2022 05:02:17 -0500 X-MC-Unique: OZBB4ZAFO-yxhw2k1sAcig-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 435378339B4; Mon, 21 Nov 2022 10:02:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 055B1112C063; Mon, 21 Nov 2022 10:02:12 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2ALA28ad004086 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 21 Nov 2022 11:02:08 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2ALA27Ti004085; Mon, 21 Nov 2022 11:02:07 +0100 Date: Mon, 21 Nov 2022 11:02:07 +0100 From: Jakub Jelinek To: Yuri Gribov Cc: GCC Patches , Martin =?utf-8?B?TGnFoWth?= Subject: Re: [PATCH][PING][sanitizer/106558] asan: fix unsafe optimization of Asan checks. Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 21, 2022 at 12:57:15PM +0300, Yuri Gribov wrote: > From 4729f2db3f1b6b40ef0124e4a645788d7f66f426 Mon Sep 17 00:00:00 2001 > From: Yuri Gribov > Date: Sun, 14 Aug 2022 08:42:44 +0300 > Subject: [PATCH] asan: fix unsafe optimization of Asan checks. > > gcc/ > PR sanitizer/106558 > * sanopt.c: Do not optimize out checks for non-SSA addresses. > > gcc/testsuite/ > PR sanitizer/106558 > * c-c++-common/asan/pr106558.c: New test. > --- > gcc/sanopt.cc | 40 +++++++++++++++++----- > gcc/testsuite/c-c++-common/asan/pr106558.c | 23 +++++++++++++ > 2 files changed, 54 insertions(+), 9 deletions(-) > create mode 100644 gcc/testsuite/c-c++-common/asan/pr106558.c > > diff --git a/gcc/sanopt.cc b/gcc/sanopt.cc > index e9d188d7889..13942a0b1da 100644 > --- a/gcc/sanopt.cc > +++ b/gcc/sanopt.cc > @@ -80,16 +80,16 @@ struct sanopt_info > > /* If T has a single definition of form T = T2, return T2. */ > > -static tree > +static gimple * > maybe_get_single_definition (tree t) > { > if (TREE_CODE (t) == SSA_NAME) > { > gimple *g = SSA_NAME_DEF_STMT (t); > if (gimple_assign_single_p (g)) > - return gimple_assign_rhs1 (g); > + return g; > } > - return NULL_TREE; > + return NULL; > } > > /* Tree triplet for vptr_check_map. */ > @@ -618,11 +618,30 @@ maybe_optimize_ubsan_vptr_ifn (class sanopt_ctx *ctx, gimple *stmt) > return true; > } > > +/* Checks whether value of T in CHECK and USE is the same. */ > + > +static bool same_value_p (gimple *check, gimple *use, tree t) Formatting. Function name should be on another line: static bool same_value_p (gimple *check, gimple *use, tree t) Otherwise LGTM. Thanks and sorry for the review delay. Jakub