From: Jakub Jelinek <jakub@redhat.com>
To: Christophe Lyon <christophe.lyon@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] genmultilib: Fix sanity check
Date: Mon, 21 Nov 2022 13:17:15 +0100 [thread overview]
Message-ID: <Y3tsSzt1NHCbW9Ys@tucnak> (raw)
In-Reply-To: <20221121115915.374247-1-christophe.lyon@arm.com>
On Mon, Nov 21, 2022 at 12:59:15PM +0100, Christophe Lyon wrote:
> My previous patch to add a sanity check to genmultilib actually
> checked the number of dirnames with the number of "sets of options"
> rather than the number of options, thus breaking the build on some
> targets.
>
> To avoid duplicating once more the loop that constructs the sed
> patterns, this patch checks that the current dirname/osdirname is not
> empty in the existing loops.
>
> Are there targets where:
> if [ "$1" != "${opt}" ]; then
> is "legally" executed with an empty $1? (and thus where this patch
> would incorrectly trigger an error?)
Dunno, let's try your patch. And if that triggers on something
valid then the next step would be just to revert the sanity checks
completely.
> * genmultilib: Fix options and dirnames/osdirnames sanity
> check.
This won't get through the pre-commit hook, the second line
should be indented just by tab and nothing further.
Jakub
next prev parent reply other threads:[~2022-11-21 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 11:59 Christophe Lyon
2022-11-21 12:17 ` Jakub Jelinek [this message]
2022-11-21 12:20 ` Christophe Lyon
2022-11-21 14:27 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3tsSzt1NHCbW9Ys@tucnak \
--to=jakub@redhat.com \
--cc=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).