From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4386A3858C20 for ; Tue, 22 Nov 2022 11:12:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4386A3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669115550; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=hn9vsynWRLcKo4sBpIrfehclRFiTE2nVmG+VbegdzIQ=; b=CmH+lDxDlymApnMTQjyrHKyG88lCvHF+xuZvxyyLDCEtOqJboxGbjIJFKFRg7ww10vioG1 IjR8etBxYzk0B6UM1altct/+bqM5jQTDzkyl2Fy4CyA8dfBbOjk+QwN6UPXGlS0d6Y5s23 okV4dunaP8xFq4NUzbvRN7KA/Fnp+P4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-104-nchHW7HEOSW-H3WSwfTwEA-1; Tue, 22 Nov 2022 06:12:29 -0500 X-MC-Unique: nchHW7HEOSW-H3WSwfTwEA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66386800B23 for ; Tue, 22 Nov 2022 11:12:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21D944A9254; Tue, 22 Nov 2022 11:12:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2AMBCOY0627423 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 22 Nov 2022 12:12:24 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2AMBCN1p627422; Tue, 22 Nov 2022 12:12:23 +0100 Date: Tue, 22 Nov 2022 12:12:23 +0100 From: Jakub Jelinek To: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: [PATCH RFA(configure)] c++: provide strchrnul on targets without it [PR107781] Message-ID: Reply-To: Jakub Jelinek References: <20221121233147.523576-1-jason@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 22, 2022 at 09:41:24AM +0100, Jakub Jelinek via Gcc-patches wrote: > On Mon, Nov 21, 2022 at 06:31:47PM -0500, Jason Merrill via Gcc-patches wrote: > > Tested x86_64-pc-linux-gnu, and also manually changing the HAVE_DECL_STRCHRNUL > > flag. OK for trunk? > > > > -- 8< -- > > > > The Contracts implementation uses strchrnul, which is a glibc extension, so > > bootstrap broke on non-glibc targets. I considered unconditionally using a > > local definition, but I guess we might as well use the libc version if it > > exists. > > > > PR c++/107781 > > > > gcc/cp/ChangeLog: > > > > * contracts.cc (strchrnul): Define if needed. > > > > gcc/ChangeLog: > > > > * configure.ac: Check for strchrnul. > > * config.in, configure: Regenerate. > > Normally we'd add such a local definition to libiberty, shouldn't we do it > in this case too? Or use strcspn as Jonathan posted in the PR, at least glibc will handle it as strchrnul (start, reject[0]) - start early in the strcspn implementation. Jakub