From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DC31F384F896 for ; Fri, 25 Nov 2022 11:25:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC31F384F896 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669375544; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=9DMDksgqbQw4LkS4R5sLcdKJw6HNvPvc5vmpOxHCVvU=; b=K0F2WGeT+vnuaPVZEP2fviasez/Vtt9w6wK8b4YXOnIOoqVxUGtvRFrTr16mf2SnvbodmF VA1hQWQZPcbGo0/dO3p0wSj2uALm7a8aKzURhYGxCVRPcsM2Jb4RzhmvbbvRM7p4zqhiEW lurFPzVR3WONGVTsOeH7nxMMzUTmvcY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-0LnI4wyeOS-M6h3jgTDoWw-1; Fri, 25 Nov 2022 06:25:43 -0500 X-MC-Unique: 0LnI4wyeOS-M6h3jgTDoWw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DCFB23C025A0; Fri, 25 Nov 2022 11:25:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F7F22166B46; Fri, 25 Nov 2022 11:25:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2APBPbO1354965 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 25 Nov 2022 12:25:38 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2APBPbbH354964; Fri, 25 Nov 2022 12:25:37 +0100 Date: Fri, 25 Nov 2022 12:25:37 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches Subject: Re: [Patch] libgomp: Add no-target-region rev offload test + fix plugin-nvptx Message-ID: Reply-To: Jakub Jelinek References: <64661eda-7f5f-da60-894f-00f90f1def04@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <64661eda-7f5f-da60-894f-00f90f1def04@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 24, 2022 at 06:48:01PM +0100, Tobias Burnus wrote: > libgomp: Add no-target-region rev offload test + fix plugin-nvptx > > OpenMP permits that a 'target device(ancestor:1)' is called without being > enclosed in a target region - using the current device (i.e. the host) in > that case. This commit adds a testcase for this. > > In case of nvptx, the missing on-device 'GOMP_target_ext' call causes that > it and also the associated on-device GOMP_REV_OFFLOAD_VAR variable are not > linked in from nvptx's libgomp.a. Thus, handle the failing cuModuleGetGlobal > gracefully by disabling reverse offload and assuming that the failure is fine. > > libgomp/ChangeLog: > > * plugin/plugin-nvptx.c (GOMP_OFFLOAD_load_image): Use unsigned int > for 'i' to match 'fn_entries'; regard absent GOMP_REV_OFFLOAD_VAR > as valid and the code having no reverse-offload code. > * testsuite/libgomp.c-c++-common/reverse-offload-2.c: New test. Ok, thanks. Jakub