From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F286D383D8E8 for ; Thu, 8 Dec 2022 13:19:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F286D383D8E8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670505551; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=TnBGpPy4hKVfrQ+Wk1OjmAJCqBlgvo0ZxAMghM2n8Qk=; b=U/xzh7o2/17DeDrARIjYgF9QugI5P9PSKygydAhwV3TJ09+g9ei3aFKz5EPAFGq9zAbebV sWDsYSsdQdzn4nEVeyBxeUeb+2iQ196haPwMDl9jlCKdMzoc+3AMbZbuiEfeCEVaVc/56r bDhlVzGrknPbVp5W7MIWPX3Rqt9agkw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-Rbc8AfTJP8WQAfGKlGQ4Tg-1; Thu, 08 Dec 2022 08:19:08 -0500 X-MC-Unique: Rbc8AfTJP8WQAfGKlGQ4Tg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 332D91C05137; Thu, 8 Dec 2022 13:19:08 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5CA3492B04; Thu, 8 Dec 2022 13:19:07 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2B8DJ33x1996161 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 8 Dec 2022 14:19:03 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2B8DJ1ZL1996160; Thu, 8 Dec 2022 14:19:01 +0100 Date: Thu, 8 Dec 2022 14:19:01 +0100 From: Jakub Jelinek To: "Jose E. Marchesi" Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] expr.cc: avoid unexpected side effects in expand_expr_divmod optimization Message-ID: Reply-To: Jakub Jelinek References: <20221208105944.660323-1-jose.marchesi@oracle.com> <87y1rixd3n.fsf@oracle.com> MIME-Version: 1.0 In-Reply-To: <87y1rixd3n.fsf@oracle.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 08, 2022 at 02:02:36PM +0100, Jose E. Marchesi wrote: > So, I guess the right fix would be to call assemble_external_libcall > during final? The `.global FOO' directive would be generated > immediately before the call sequence, but I guess that would be ok. During final only if all the targets can deal with the effects of assemble_external_libcall being done in the middle of emitting assembly for the function. Otherwise, it could be e.g. done in the first loop of shorten_branches. Note, in calls.cc it is done only for emit_library_call_value_1 and not for emit_call_1, so if we do it late, we need to be able to find out what call is to a libcall and what is to a normal call. If there is no way to differentiate it right now, perhaps we need some flag somewhere, say on a SYMBOL_REF. And then assemble_external_libcall either only if such a SYMBOL_REF appears in CALL_INSN or sibcall JUMP_INSN, or perhaps anywhere in the function and its constant pool. Jakub