From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/9] ipa-cp: Write transformation summaries of all functions
Date: Mon, 12 Dec 2022 21:37:19 +0100 [thread overview]
Message-ID: <Y5eQ/x7hFg9yJ2QD@kam.mff.cuni.cz> (raw)
In-Reply-To: <ri67cywimyy.fsf@suse.cz>
> -void
> -write_ipcp_transformation_info (output_block *ob, cgraph_node *node)
> +/* Return true if the IPA-CP transformation summary TS is non-NULL and contains
> + useful info. */
> +static bool
> +useful_ipcp_transformation_info_p (ipcp_transformation *ts)
> {
> - int node_ref;
> - unsigned int count = 0;
> - lto_symtab_encoder_t encoder;
> + if (!ts)
> + return false;
> + if (!vec_safe_is_empty (ts->m_agg_values)
> + || !vec_safe_is_empty (ts->bits)
> + || !vec_safe_is_empty (ts->m_vr))
> + return true;
> + return false;
> +}
Hi,
If I remmeber correctly, we discussed this patch and wanted to change
the boundary computation code to set encode_body also for masters of
clones which are needed in a given partition so we can test the flag
here. Was there problem with this approach?
I will review rest of series this week.
Honza
next prev parent reply other threads:[~2022-12-12 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 16:52 Martin Jambor
2022-12-12 20:37 ` Jan Hubicka [this message]
2022-12-12 21:43 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5eQ/x7hFg9yJ2QD@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).