From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 7FA2F38533FC for ; Mon, 12 Dec 2022 21:56:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7FA2F38533FC Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kam.mff.cuni.cz Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id A4B5728088F; Mon, 12 Dec 2022 22:56:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1670882213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k5/9GpzQJL9gzBh66SBVmnVIQ5vQA5pv851NDz1JvHQ=; b=p4Mk3sYXdCVzsPwXf0+Q8DXFRPVRAOpmdaMrb3U1oLfZYWMwVLlmo4rz9j8biUhskGNzyn ii0IGSdchJig2K6vpooZTy4gc3lssiSG1bSKQnrMuUFPQGjQS3dVmtnaBZT+fR773r/83L mg51nFZGyCTbKK3NvNy8fi2/tui9uhg= Date: Mon, 12 Dec 2022 22:56:53 +0100 From: Jan Hubicka To: Martin Jambor Cc: GCC Patches Subject: Re: [PATCH 9/9] ipa: Avoid looking for IPA-SRA replacements where there are none Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi, > > I'm re-posting patches which I have posted at the end of stage 1 but > which have not passed review yet. > > 8<-------------------------------------------------------------------- > > While modifying the code, I realized that we do look into statements > even when there are no replacements. This patch adds the necessary > early bail-outs to avoid that. > > ipa_param_body_adjustments::modify_call_stmt cannot have the same at > the very beginning because calls can still contain otherwise removed > parameters that need to be removed from the statements too. > > Bootstrapped and tested individually when I originally posted it and > now bootstrapped and LTO-bootstrapped and tested as part of the whole > series. OK for master? > > > gcc/ChangeLog: > > 2022-11-11 Martin Jambor > > * ipa-param-manipulation.cc > (ipa_param_body_adjustments::modify_expression): Bail out early if > there are no replacements. > (ipa_param_body_adjustments::modify_assignment): Likewise. > > gcc/testsuite/ChangeLog: > > 2022-11-11 Martin Jambor > > PR ipa/103227 > PR ipa/107640 > * gcc.dg/ipa/pr107640-2.c: New test. OK, thanks! Honza