From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3D4C6384468F for ; Thu, 15 Dec 2022 17:24:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D4C6384468F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671125066; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=W674yLrSgtsZsi1vhdrcBNea7UdChOWgC4Wp9lxMwrw=; b=EZTYnsZU4BrdrGNPnm1VoJizLeMEeLpLARucTifh0RS9uuvksaQ6pS5EHXJW9oyzeSmlpS bSqIvqqggxrP+7NyXmcqeFEnNuynYwsWwNPNl3yvejH/TmJZPJuAwzuCTXFyNMbdXkFKSa 91uYTEwsNl6L4aWazv3zNr48PIY43wk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-424-dOcxypreN1W94bqccEksVA-1; Thu, 15 Dec 2022 12:24:24 -0500 X-MC-Unique: dOcxypreN1W94bqccEksVA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 896AB1805666; Thu, 15 Dec 2022 17:24:24 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 490AC49BB6A; Thu, 15 Dec 2022 17:24:24 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2BFHOJrh3330228 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 15 Dec 2022 18:24:19 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2BFHOImf3330227; Thu, 15 Dec 2022 18:24:18 +0100 Date: Thu, 15 Dec 2022 18:24:18 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] doc: Fix documentation for __builtin_dynamic_object_size Message-ID: Reply-To: Jakub Jelinek References: <20221215165814.1808816-1-siddhesh@gotplt.org> <7cb1073c-86ed-7ff0-ff3b-14e288b86df8@gotplt.org> MIME-Version: 1.0 In-Reply-To: <7cb1073c-86ed-7ff0-ff3b-14e288b86df8@gotplt.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 15, 2022 at 12:21:21PM -0500, Siddhesh Poyarekar wrote: > On 2022-12-15 12:09, Jakub Jelinek wrote: > > > -This is a propagation pass similar to CCP that tries to remove calls > > > -to @code{__builtin_object_size} when the size of the object can be > > > -computed at compile-time. This pass is located in > > > -@file{tree-object-size.cc} and is described by > > > +This is a propagation pass similar to CCP that tries to remove calls to > > > +@code{__builtin_object_size} or @code{__builtin_dynamic_object_size} > > > +when the size of the object can be computed at compile-time. This pass > > > > Can be computed at compile-time is only true for __bos, for > > __bdos is if it can be computed. > > How about: > > > This is a propagation pass similar to CCP that tries to remove calls to > @code{__builtin_object_size} when the size of the object can be computed at > compile-time. It also tries to replace calls to > > @code{__builtin_dynamic_object_size} with an expression that evaluates > the size of the object. This pass is located in > @file{tree-object-size.cc} and is described by @code{pass_object_sizes}. Without the empty space in between and perhaps with replacing size with upper or lower bound for the size of the object in both cases ok. Jakub