From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AEFB83857BB3 for ; Mon, 19 Dec 2022 13:54:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AEFB83857BB3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671458076; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ELJ7SnxvCvVNI5l3qAh2FHGQL76j051pUvRHpjOdx60=; b=eBQ65xiLspEz/LDeG4sdK+ZlxSdV6nOkAOP0ZXQYhC5oHqoguLIUC2hK734lx/mHYfdg5+ s9bxn67KP2f3/GxPC5cl5DU7UsNj432aXZIVaxk3vfcdU+E5bAH0GqmeYB6kXg6YEg6hxZ iHMFQnFnbBGaty1klKd+bn+ZwK2B8sY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-5-fYoFUtJEP1-oRd2Cch8nBQ-1; Mon, 19 Dec 2022 08:54:35 -0500 X-MC-Unique: fYoFUtJEP1-oRd2Cch8nBQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AE1942A59557; Mon, 19 Dec 2022 13:54:34 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D10540C2064; Mon, 19 Dec 2022 13:54:34 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 2BJDsVDc778483 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 19 Dec 2022 14:54:32 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 2BJDsU7X778482; Mon, 19 Dec 2022 14:54:30 +0100 Date: Mon, 19 Dec 2022 14:54:30 +0100 From: Jakub Jelinek To: Martin =?utf-8?B?TGnFoWth?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH (pushed)] gcc-changelog: allow digit in component name Message-ID: Reply-To: Jakub Jelinek References: <0b81f2a6-f80a-f28e-c731-5086b436e26a@suse.cz> MIME-Version: 1.0 In-Reply-To: <0b81f2a6-f80a-f28e-c731-5086b436e26a@suse.cz> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 19, 2022 at 02:40:29PM +0100, Martin Liška wrote: > contrib/ChangeLog: > > * gcc-changelog/git_commit.py: Allow digit in component name. > > contrib/ChangeLog: > > * gcc-changelog/test_email.py: Add new test. > * gcc-changelog/test_patches.txt: Add new patch. > --- > contrib/gcc-changelog/git_commit.py | 2 +- > contrib/gcc-changelog/test_email.py | 4 ++++ > contrib/gcc-changelog/test_patches.txt | 25 +++++++++++++++++++++++++ > 3 files changed, 30 insertions(+), 1 deletion(-) > > diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py > index e82fbcacd3e..7fde02cba85 100755 > --- a/contrib/gcc-changelog/git_commit.py > +++ b/contrib/gcc-changelog/git_commit.py > @@ -165,7 +165,7 @@ additional_author_regex = re.compile(r'^\t(?P\ *)?(?P.* <.*>)') > changelog_regex = re.compile(r'^(?:[fF]or +)?([a-z0-9+-/]*)ChangeLog:?') > subject_pr_regex = re.compile(r'(^|\W)PR\s+(?P[a-zA-Z+-]+)/(?P\d{4,7})') What about the above regex, shouldn't that be adjusted too? > subject_pr2_regex = re.compile(r'[(\[]PR\s*(?P\d{4,7})[)\]]') > -pr_regex = re.compile(r'\tPR (?P[a-z+-]+\/)?(?P[0-9]+)$') > +pr_regex = re.compile(r'\tPR (?P[a-z0-9+-]+\/)?(?P[0-9]+)$') > dr_regex = re.compile(r'\tDR ([0-9]+)$') > star_prefix_regex = re.compile(r'\t\*(?P\ *)(?P.*)') > end_of_location_regex = re.compile(r'[\[<(:]') Jakub