From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 612533858C74 for ; Thu, 12 Jan 2023 10:39:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 612533858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673519957; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=i2k68wKWNxQnlc8e+HZ6ONdhexwlrWABzZdcEfp8WbM=; b=DIeEUILMBFd6SIhLkcXyUTeK1cXVrsEUd39308VwH918DGGCmhSYs6t8lFeu8UppwoFDkl sYfUKJyiOluQ3FvUvQtjM08b8mMsws8l7ZavFGArrmU3k+heh5ilMXeLhpZQquvoVWq3DA m1p75tsKJOlHc6pnjodWPdfHMv4HYvc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-292-5QJACLNUPLmhKP4kbj7D1w-1; Thu, 12 Jan 2023 05:39:13 -0500 X-MC-Unique: 5QJACLNUPLmhKP4kbj7D1w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 384D42802E29; Thu, 12 Jan 2023 10:39:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8F4F1121314; Thu, 12 Jan 2023 10:39:12 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30CAd9In3415201 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 11:39:10 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30CAd9RV3415200; Thu, 12 Jan 2023 11:39:09 +0100 Date: Thu, 12 Jan 2023 11:39:08 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran/OpenMP: Reject non-scalar 'holds' expr in 'omp assume(s)' [PR107424] Message-ID: Reply-To: Jakub Jelinek References: <6cd99975-646d-a122-d844-c194dce8dbd0@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <6cd99975-646d-a122-d844-c194dce8dbd0@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jan 12, 2023 at 11:22:40AM +0100, Tobias Burnus wrote: > Rather obvious fix for that ICE. > > Comments? If there are none, I will commit it later as obvious. I think the spec should be clarified, unlike clauses like if, novariants, nocontext, indirect, final clause operands where we specify the argument to be expression of logical type and glossary term says that OpenMP logical expression is scalar expression for C/C++ and scalar logical expression for Fortran. But for the holds clause, all we say is that holds clause isn't inarguable and "the program guarantees that the listed expression evaluates to true in the assumption scope. The effect of the clause does not include an observable evaluation of the expression." so I think making it clear that holds argument is expression of logical type would be useful. That said, the patch is ok, a rank > 1 expression can't be considered to evaluate to true... Jakub