From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 990903858CDA for ; Tue, 10 Jan 2023 10:46:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 990903858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673347588; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=y5ZetrfshViwuZukcyM131QxQbFSKnMrm6ylNEg2iKw=; b=iGo94BPXKP/Czg8yduFV9LrJL+6Mlg2XXAKZ3YXg7JRCpoe4Eu7uaJcmck07Qe99g18GDd kirvQ9BY36llSUOvNIPhd/+l6hOuXqN3mKoZFLVB6QAyOidkz7QP6PzeFw+L7yO7TQNAC4 7xGAn4zSvZW2gsJUm9I5QJpEzXFwBuQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-367-GWmRYpJwNb2vVJy97_JRVQ-1; Tue, 10 Jan 2023 05:46:27 -0500 X-MC-Unique: GWmRYpJwNb2vVJy97_JRVQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9BD83101A52E; Tue, 10 Jan 2023 10:46:26 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58B89140EBF4; Tue, 10 Jan 2023 10:46:26 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30AAkI7s2742588 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 11:46:19 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30AAkI1H2742587; Tue, 10 Jan 2023 11:46:18 +0100 Date: Tue, 10 Jan 2023 11:46:17 +0100 From: Jakub Jelinek To: Richard Biener Cc: Gaius Mulley , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, Modula2] PR-108142 Many empty directories created in the build directory Message-ID: Reply-To: Jakub Jelinek References: <87h6wzf9ci.fsf@debian> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 10, 2023 at 11:16:28AM +0100, Richard Biener via Gcc-patches wrote: > > @@ -424,7 +388,7 @@ override PLUGINCFLAGS := $(filter-out -mdynamic-no-pic,$(PLUGINCFLAGS)) > > > > plugin/m2rte$(soext): $(srcdir)/m2/plugin/m2rte.cc $(GCC_HEADER_DEPENDENCIES_FOR_M2) \ > > insn-attr-common.h insn-flags.h $(generated_files) > > - test -d plugin || mkdir plugin > > + -test -d plugin || $(mkinstalldirs) plugin > > I wonder if that's possibly racy (that's why you use mkinstalldirs?)? Using $(mkinstalldirs) in the patch is what I've suggested because previously the patch was using mkdir -p which we almost never use (I think only some Ada Makefiles). Above when it is a single directory mkdir is fine. -test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR) etc. is what is used in gcc/Makefile.in in some spots. If 2 shells do that test -d plugin || mkdir plugin at the same time, then yes, both might do mkdir, but that is why we have the - at the start, the error of doing mkdir twice will be ignored then. Jakub