From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D8DB93858D33 for ; Tue, 10 Jan 2023 18:12:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8DB93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673374364; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=KJntWRnBvEHJZ6oFvBMKKEmSNIdddg4UdM7iVbipQMQ=; b=cKzjXPrS5yL2xILomygUTSRjKPjM1YyBhMpc+TTfMo5DxKuxqTUd3dLQU4WYy/WVwZ0+Hm uEs3fjBCKpmQcSXMN68pZAIJwCTnV1cP5s91qw0OBpg/09RDKf5ogMH+tePBinm30p24dS L+JXLFXA90f1X3lemhcGUOYS0PnSAB8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-pbb2Qd3aMmuMXHep9sT8FQ-1; Tue, 10 Jan 2023 13:12:41 -0500 X-MC-Unique: pbb2Qd3aMmuMXHep9sT8FQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBD2180D0E9; Tue, 10 Jan 2023 18:12:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A379D422F2; Tue, 10 Jan 2023 18:12:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30AICaq92777074 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 19:12:37 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30AICZed2777073; Tue, 10 Jan 2023 19:12:35 +0100 Date: Tue, 10 Jan 2023 19:12:34 +0100 From: Jakub Jelinek To: Wilco Dijkstra Cc: Szabolcs Nagy , Richard Sandiford , GCC Patches Subject: Re: [PATCH] libgcc: Fix uninitialized RA signing on AArch64 [PR107678] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 10, 2023 at 04:33:59PM +0000, Wilco Dijkstra via Gcc-patches wrote: > @@ -1204,10 +1203,15 @@ execute_cfa_program (const unsigned char *insn_ptr, > case DW_CFA_GNU_window_save: > #if defined (__aarch64__) && !defined (__ILP32__) > /* This CFA is multiplexed with Sparc. On AArch64 it's used to toggle > - return address signing status. */ > + return address signing status. The REG_UNDEFINED/UNSAVED states > + mean RA signing is enabled/disabled. */ > reg = DWARF_REGNUM_AARCH64_RA_STATE; > - gcc_assert (fs->regs.how[reg] == REG_UNSAVED); > - fs->regs.reg[reg].loc.offset ^= 1; > + gcc_assert (fs->regs.how[reg] == REG_UNSAVED > + || fs->regs.how[reg] == REG_UNDEFINED); > + if (fs->regs.how[reg] == REG_UNSAVED) > + fs->regs.how[reg] = REG_UNDEFINED; > + else > + fs->regs.how[reg] = REG_UNSAVED; Wouldn't the assert be better written just as: if (fs->regs.how[reg] == REG_UNSAVED) fs->regs.how[reg] = REG_UNDEFINED; else { gcc_assert (fs->regs.how[reg] == REG_UNDEFINED); fs->regs.how[reg] = REG_UNSAVED; } ? Anyway, the sooner this makes it into gcc trunk, the better, it breaks quite a lot of stuff. Jakub