From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id ECDDB3858C62 for ; Wed, 11 Jan 2023 19:26:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECDDB3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673465218; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Htd6riJjsU18JbNdJ9En+Orv/IVX6WNqhHmtZWUFnao=; b=SUHOJVuVjIC2ejwm/xckrvpYAUIVoowUGFWCWYON/+QNgoPQhlAsp/6xx0L+wg5NloLUzL LjJznMgQ1cOqEWzgpb3oCyoe8k/YU01hWyJ5kGcxlOM9UfQVQIR2iBP9Qz2e1X4R6aRwY8 5q5eIGPjLOu1nQgINlEno5mVG/fdpnk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-FmBYZh8_ME65vNQ2pqe-4A-1; Wed, 11 Jan 2023 14:26:55 -0500 X-MC-Unique: FmBYZh8_ME65vNQ2pqe-4A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48B643806704; Wed, 11 Jan 2023 19:26:55 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04E512166B26; Wed, 11 Jan 2023 19:26:54 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30BJQq0t3410428 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 20:26:52 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30BJQpJh3410426; Wed, 11 Jan 2023 20:26:51 +0100 Date: Wed, 11 Jan 2023 20:26:51 +0100 From: Jakub Jelinek To: Lewis Hyatt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] preprocessor: Don't register pragmas in directives-only mode [PR108244] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 30, 2022 at 12:21:37PM -0500, Lewis Hyatt via Gcc-patches wrote: > libcpp's directives-only mode does not expect deferred pragmas to be > registered, but to date the c-family registration process has not checked for > this case. That issue became more visible since r13-1544, which added the > commonly used GCC diagnostic pragmas to the set of those registered in > preprocessing modes. Fix it by checking for directives-only mode in > c-family/c-pragma.cc. > > gcc/c-family/ChangeLog: > > PR preprocessor/108244 > * c-pragma.cc (c_register_pragma_1): Don't attempt to register any > deferred pragmas if -fdirectives-only. > (init_pragma): Likewise. > > gcc/testsuite/ChangeLog: > > * c-c++-common/cpp/pr108244-1.c: New test. > * c-c++-common/cpp/pr108244-2.c: New test. > * c-c++-common/cpp/pr108244-3.c: New test. Ok, with a nit: > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/cpp/pr108244-3.c > @@ -0,0 +1,6 @@ > +/* { dg-do preprocess } */ > +/* { dg-additional-options "-fdirectives-only -fopenmp" } */ > +/* { dg-require-effective-target "fopenmp" } */ > +#pragma omp parallel > +#ifdef t > +#endif This test should be in gcc/testsuite/c-c++-common/gomp/ directory instead, without the dg-require-effective-target. Jakub