From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D9BC23858439 for ; Tue, 24 Jan 2023 10:58:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9BC23858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674557899; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=SRcq3RHHEx1yFRYyuRCtJcLclb9bK6JhiEN9LBAvR84=; b=Zhi6k2ZDj9KPnH9nIkKNERO/X3rum6jRNsO6R3GoYQlx6/ToY4Cx3SGPyYIDFQdBpf7zo+ YLs6YyjuBPO495ejxP9+jbvJ9eDfdQ4cdfKT1k4fcMyu/dXeebvXdec28YDJsgg31V2JqA HORYsO9xFsLD/Dpm4RVzz25ixNlZMkU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-qH0QuSyaO36ha9ZqMiZmow-1; Tue, 24 Jan 2023 05:58:18 -0500 X-MC-Unique: qH0QuSyaO36ha9ZqMiZmow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E643285CBE0; Tue, 24 Jan 2023 10:58:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A29FE39DB3; Tue, 24 Jan 2023 10:58:17 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30OAwEWV466983 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 11:58:15 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30OAwEw1466982; Tue, 24 Jan 2023 11:58:14 +0100 Date: Tue, 24 Jan 2023 11:58:13 +0100 From: Jakub Jelinek To: Eric Biggers , Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] options: fix cl_target_option_print_diff() with strings Message-ID: Reply-To: Jakub Jelinek References: <20230124041453.2595798-1-ebiggers@google.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 24, 2023 at 10:37:43AM +0000, Jonathan Wakely wrote: > Changing CC to gcc-patches instead of gcc-bugs ... The fix is obvious, so I've committed it. Thanks. > On 24/01/23 04:14 +0000, Eric Biggers wrote: > > Fix an obvious copy-and-paste error where ptr1 was used instead of ptr2. > > This bug caused the dump file produced by -fdump-ipa-inline-details to > > not correctly show the difference in target options when a function > > could not be inlined due to a target option mismatch. Though, if you have a small reproducer, it would be nice to include it in GCC testsuite. > > > > gcc/ChangeLog: > > > > * optc-save-gen.awk: Fix copy-and-paste error. > > > > Fixes: b54ecc769f59 ("re PR bootstrap/90543 (Build failure on MINGW for gcc-9.1.0)") The above line doesn't belong here, instead PR bootstrap/90543 should be above the * optc-save-gen.awk ... line. > > Signed-off-by: Eric Biggers > > --- > > gcc/optc-save-gen.awk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gcc/optc-save-gen.awk b/gcc/optc-save-gen.awk > > index e91adf7f132..d2cb53c477f 100644 > > --- a/gcc/optc-save-gen.awk > > +++ b/gcc/optc-save-gen.awk > > @@ -1013,7 +1013,7 @@ for (i = 0; i < n_target_string; i++) { > > print " indent, \"\","; > > print " \"" name "\","; > > print " ptr1->x_" name " ? ptr1->x_" name " : \"(null)\","; > > - print " ptr2->x_" name " ? ptr1->x_" name " : \"(null)\");"; > > + print " ptr2->x_" name " ? ptr2->x_" name " : \"(null)\");"; > > print ""; > > } > > > > -- > > 2.39.1.405.gd4c25cc71f-goog > > Jakub