From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4D8593858D1E for ; Tue, 24 Jan 2023 09:36:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D8593858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674552977; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cz3ZyDTmz40ERuxuKhcWw0M24D7zg3rQOWc9hO7D6dY=; b=MGkwNj2qF6MeIElB2t7PZT1UdNvTtmhCCdnyc98aVIBHFNVIifuDI3i7RQXTCutQe4sE1w Z9pdVOskl9tcqrsCeWq8HBNfRsDulR/li6/hWQ/Qj7ashZdc5hg41xVOXCDP0+wpvItJv/ L+E/vR3Fbny/thfvljERetRz+kRLcJg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-263-OdBheYyYPGutH8t_5XGVAg-1; Tue, 24 Jan 2023 04:36:16 -0500 X-MC-Unique: OdBheYyYPGutH8t_5XGVAg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3E2D688B776; Tue, 24 Jan 2023 09:36:16 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3FFD492C3C; Tue, 24 Jan 2023 09:36:15 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30O9aDna466088 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 24 Jan 2023 10:36:13 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30O9aCH7466087; Tue, 24 Jan 2023 10:36:12 +0100 Date: Tue, 24 Jan 2023 10:36:12 +0100 From: Jakub Jelinek To: Andrew MacLeod Cc: gcc-patches , "hernandez, aldy" , Richard Biener Subject: Re: [PATCH 1/2] Use value_relation class instead of direct calls to intersect/union. Message-ID: Reply-To: Jakub Jelinek References: <2b7a5b75-aa71-b399-ff07-1f62dfac6cdc@redhat.com> MIME-Version: 1.0 In-Reply-To: <2b7a5b75-aa71-b399-ff07-1f62dfac6cdc@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 23, 2023 at 12:44:42PM -0500, Andrew MacLeod wrote: > In order to fix 108447, this patch changes the calls to relation_union and > relation_intersection to instead utilize the value_relation class, and make > the calls through that instead. > > value_relation manages the operands of a relation, and thus understands > whether this is a floating point relation and can make any adjustments > required to get the proper results.  THis patch doesn't do anything > additional, just that isolation so we can track if it introduces anything > speerate from the next change which adds another relation. > > Bootstraps on x86_64-pc-linux-gnu with no regressions.  OK? LGTM. Jakub