From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E39323858D33 for ; Mon, 23 Jan 2023 10:20:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E39323858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674469258; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8gG5XczqTs08UvhG0B6P9ss3nk/4RqzHyUmEMLGH00w=; b=HfJwU0E/LObnbKYXVSNEb/ewA2QvWaL+6et1hNGwittXHAZ1oUo3op38vj7KnzaDblZA/V 3SGtWT+/rD0vuMwLtOezmyIhDA8Wk0OMiS59UGsRwEGkIlgKfU0DLA3cNyfjs0rC0bR+qn ZXE12nlVmriH+YbZrPZodgNOinM399Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-15ykCCpKOci20FpssSFPxw-1; Mon, 23 Jan 2023 05:20:57 -0500 X-MC-Unique: 15ykCCpKOci20FpssSFPxw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEDF2101AA63; Mon, 23 Jan 2023 10:20:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BB3140C1141; Mon, 23 Jan 2023 10:20:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30NAKrLl1538773 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Jan 2023 11:20:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30NAKqkW1538772; Mon, 23 Jan 2023 11:20:52 +0100 Date: Mon, 23 Jan 2023 11:20:52 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/108482 - remove stray .LOOP_DIST_ALIAS calls Message-ID: Reply-To: Jakub Jelinek References: <20230123100943.6C675134F5@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20230123100943.6C675134F5@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 23, 2023 at 11:09:43AM +0100, Richard Biener wrote: > The following deals with .LOOP_DIST_ALIAS surviving vectorization > because any of the loops involved were elided between loop distribution > and vectorization. As opposed to .LOOP_VECTORIZED which exists only > between if-conversion and vectorization with no intermediate passes > this is more difficult to deal with in advance and thus cleaning > up after vectorization looks better. There's the unconditional > vector lowering pass which looks like a good place for this (for > SIMD uid we have pass_simduid_cleanup). > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > OK? I admit I didn't know something like LOOP_DIST_ALIAS even exist until today. Anyway, I wonder if there is still time to clean up during/after veclower21. I see fold_loop_internal_call propagates the return value to immediate uses and cfg_changed means we'll clean up the cfg, is that enough? Jakub