From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 722693858C39 for ; Fri, 13 Jan 2023 18:05:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 722693858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673633147; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DrtTE5KZpRlnYvevZD895y3hrzBvJPs7Z+JXNhf0jgo=; b=VdY0hwGmboxY+WG9+XTizuJDoWJ5AqFaYVnwiTCH4BMr/a1TXWre9OSlfh1lC/Nq/Q7DW6 T5lLD5rrVPVERpO8yaARMzbXOjxMX0BNJ6+N4ggxm3oRE9csqAc2NS02+X5H5LVxRIbkQX oimwQcPUC0ME+0uRbmDbUOZENDQyXKI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-k3LE386POYSAJeiQV2S_Bg-1; Fri, 13 Jan 2023 13:05:39 -0500 X-MC-Unique: k3LE386POYSAJeiQV2S_Bg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4AD9C1C426A8; Fri, 13 Jan 2023 18:05:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0745614171B7; Fri, 13 Jan 2023 18:05:38 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30DI5ajb1364005 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 13 Jan 2023 19:05:36 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30DI5ZPH1364004; Fri, 13 Jan 2023 19:05:35 +0100 Date: Fri, 13 Jan 2023 19:05:34 +0100 From: Jakub Jelinek To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH 2/3] rs6000: Delete PRE_GCC3_DWARF_FRAME_REGISTERS Message-ID: Reply-To: Jakub Jelinek References: <87d86acc61792d5a094148360a5b46f4a4a3ba01.1557171132.git.segher@kernel.crashing.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 06, 2019 at 09:55:50PM +0000, Segher Boessenkool wrote: > We don't need this. > > > Segher > > > 2019-05-06 Segher Boessenkool > > * config/rs6000/rs6000.h (PRE_GCC3_DWARF_FRAME_REGISTERS): Delete. Why do you think so? This seems to be a clear ABI break to me in the __frame_state_for API. So, if a __frame_state_for caller calls the function, it will overflow the buffer passed by the caller. > diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h > index ff9449c..3829e8f 100644 > --- a/gcc/config/rs6000/rs6000.h > +++ b/gcc/config/rs6000/rs6000.h > @@ -817,9 +817,6 @@ enum data_align { align_abi, align_opt, align_both }; > > #define FIRST_PSEUDO_REGISTER 115 > > -/* This must be included for pre gcc 3.0 glibc compatibility. */ > -#define PRE_GCC3_DWARF_FRAME_REGISTERS 77 > - > /* The sfp register and 3 HTM registers > aren't included in DWARF_FRAME_REGISTERS. */ > #define DWARF_FRAME_REGISTERS (FIRST_PSEUDO_REGISTER - 4) > -- > 1.8.3.1 Jakub