From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E57F13858D28 for ; Tue, 17 Jan 2023 11:34:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E57F13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673955243; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8wJUbIUhLnIQF0kgIJ1EpuTD2IcKwPCBXPUnVD0uUgM=; b=ANxFXXoQrso1sJg9kIx0njXWgHGx99ExmRgoyMDbwaWnJHK6oGd14MdLdzlg+IKp7NLnl3 xPNzDDKg8cjZ3RkfdM6dJLzkF7C4LfykhRiZxMObamUXjHDyBFpLuGTlAZvqVLH9yiWCqq o12EcCKMCMeYYZ9H6gxQP59Qas4cqBs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-36-uBpDugWdP4-6z3392AEyrg-1; Tue, 17 Jan 2023 06:34:02 -0500 X-MC-Unique: uBpDugWdP4-6z3392AEyrg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1689C3811F3B; Tue, 17 Jan 2023 11:34:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C525C1121315; Tue, 17 Jan 2023 11:34:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30HBXwXL1473055 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 17 Jan 2023 12:33:58 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30HBXvjX1473054; Tue, 17 Jan 2023 12:33:57 +0100 Date: Tue, 17 Jan 2023 12:33:57 +0100 From: Jakub Jelinek To: Aldy Hernandez Cc: Richard Biener , Andrew MacLeod , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] forwprop: Fix up rotate pattern matching [PR106523] Message-ID: Reply-To: Jakub Jelinek References: <675a8a92-74da-9633-ffe0-8f3ee7d6bf57@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 17, 2023 at 12:22:42PM +0100, Aldy Hernandez wrote: > > > On 1/17/23 12:19, Jakub Jelinek wrote: > > On Tue, Jan 17, 2023 at 12:14:14PM +0100, Aldy Hernandez wrote: > > > > A question would be if it would be worth to activate it in this spot lazily > > > > if it isn't active yet (and destruct at the end of the pass). > > > > > > That's what it was designed for :). If you're making sporadic requests, the > > > on-demand mechanism should be fast enough. > > > > So what should be done to do the on-demand query rather than global one? > > gimple_ranger ranger; > if (ranger.range_of_expr (r, .....)) > // business as usual So not worth making the ranger somewhere in the pass (if it is really sporadic like this one)? Will test together with the removal of B from the range. Jakub