From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E15F43858D28 for ; Wed, 18 Jan 2023 12:47:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E15F43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674046036; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=qiGawZv2FPNZhYzeSQsn0J/+wtqhLDcGj1gRhUhoCQA=; b=ZHHNpQWnvNsOR55xs/awE3lTqrY70dfzal2hPcp2mEPWFA2LY9LQztoTP82vYfdhzfswpe IKM056a0On8nrXbXj4qxTdGFCbC9YrrQEargesk9x/VTFekUHNLochYk7FXoTLnvHSl9ES E7iCxH8LxhcD4fqfCl39+lmqpaJ7Lpk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-Nlw0X3NdPV2wvUzZ3sHe8Q-1; Wed, 18 Jan 2023 07:47:13 -0500 X-MC-Unique: Nlw0X3NdPV2wvUzZ3sHe8Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B46F4857D0D; Wed, 18 Jan 2023 12:47:12 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70563C15BAD; Wed, 18 Jan 2023 12:47:12 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30ICl2ot1500332 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 18 Jan 2023 13:47:08 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30ICl1kH1500331; Wed, 18 Jan 2023 13:47:01 +0100 Date: Wed, 18 Jan 2023 13:47:01 +0100 From: Jakub Jelinek To: Andreas Schwab Cc: Richard Biener , Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] lto: pass through -funwind-tables and -fasynchronous-unwind-tables Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 18, 2023 at 01:39:18PM +0100, Andreas Schwab wrote: > On Jan 18 2023, Jakub Jelinek wrote: > > > With LTO each function has the DECL_FUNCTION_SPECIFIC_OPTIMIZATION > > (and _TARGET), for functions with optimize attribute obviously as without > > LTO specific to what options have been overridden (but with defaults from > > TU's command line etc.), for functions without that simply with what > > options has the TU. > > Sorry, I cannot parse that sentence. Could you please try again? After parsing options GCC creates an OPTIMIZATION_NODE tree with all the PerFunction/Optimization option state recorded in it (and more). That node is then when writing LTO attached to each function (different node if a function has optimize attribute etc.). That is streamed in by lto1 back and on each set_cfun such saved options are stored into global_options{,_set}. > > lto1 then streams in those options and when switching functions switches > > the global options. > > Why does that not work then? I don't know what doesn't work. You haven't mentioned what kind of PR you're trying to fix or what problem you are seeing. Jakub