From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 66B743858D35 for ; Wed, 18 Jan 2023 15:19:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66B743858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674055191; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Zmn32e+PyumGjP5M/jTY6IMSysIazLKPbZOjjxKEDh8=; b=FrVr1Fbv2ooFMM4lLX9xlc8G3wfNkmwKX/smoJAa4TKVteB77EiPqFQO+gIDdGDz2yw4Re saZi2Nm6DLNtmPlvrobHGbSu2yDR+qbFU9dwkOla5pg3Yg0FKERKrqjqb49b+rY4OHZF4n Xv1wu1yNHBWwehsRGnLHc6AU2vD/Gp0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-437-raEcKMizNfKmnVYiTfeRcg-1; Wed, 18 Jan 2023 10:19:50 -0500 X-MC-Unique: raEcKMizNfKmnVYiTfeRcg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B50F185C069; Wed, 18 Jan 2023 15:19:49 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C33CC15BAE; Wed, 18 Jan 2023 15:19:49 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30IFJk3F1502539 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 18 Jan 2023 16:19:46 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30IFJiog1502538; Wed, 18 Jan 2023 16:19:44 +0100 Date: Wed, 18 Jan 2023 16:19:44 +0100 From: Jakub Jelinek To: Michael Matz Cc: Andreas Schwab , gcc-patches@gcc.gnu.org, Richard Biener , Jan Hubicka Subject: Re: [PATCH] lto: pass through -funwind-tables and -fasynchronous-unwind-tables Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jan 18, 2023 at 03:16:07PM +0000, Michael Matz wrote: > On Wed, 18 Jan 2023, Jakub Jelinek wrote: > > > On Wed, Jan 18, 2023 at 04:09:08PM +0100, Andreas Schwab wrote: > > > On Jan 18 2023, Jakub Jelinek wrote: > > > > > > > Partly OT, what is riscv not defaulting that on as well? Does it have > > > > usable unwind info even without that option, something else? > > > > > > The RISC-V ABI does not address this, AFAICS. > > > > And neither do many other ABIs, still we default there to > > -fasynchronous-unwind-tables because we've decided it is a good idea. > > That might or might not be, but in the context of this thread that's > immaterial. Doing the same as the other archs will then simply hide the > problem on risc-v as well, instead of fixing it. Yeah, that is why I've mentioned "Partly OT". We want this bug to be fixed (but the fix is not what has been posted but rather decide what we want to ask there; if it is at the end of compilation, whether it is at least one function with that flag has been compiled, or all functions have been with that flag, something else), and IMHO riscv should switch to -fasynchronous-unwind-tables by default. Jakub