From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Jakub Jelinek via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451]
Date: Fri, 3 Feb 2023 12:20:46 -0800 [thread overview]
Message-ID: <Y91snp1XVHMlxLq+@troutmask.apl.washington.edu> (raw)
In-Reply-To: <Y91ah+TPG01V1g/A@tucnak>
On Fri, Feb 03, 2023 at 08:03:36PM +0100, Jakub Jelinek via Fortran wrote:
> Hi!
>
> The first testcase in the PR (which I haven't included in the patch because
> it is unclear to me if it is supposed to be valid or not) ICEs since extra
> hash table checking has been added recently. The problem is that
> gfc_trans_use_stmts does
> tree *slot = entry->decls->find_slot_with_hash (rent->use_name, hash,
> INSERT);
> if (*slot == NULL)
> and later on doesn't store anything into *slot and continues. Another spot
> a few lines later correctly clears the slot if it decides not to use the
> slot, so the following patch does the same.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
Yes.
See my comment in the PR about the testcases being invalid Fortran.
--
Steve
prev parent reply other threads:[~2023-02-03 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 19:03 Jakub Jelinek
2023-02-03 20:20 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y91snp1XVHMlxLq+@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).