From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9CC123858C74 for ; Thu, 26 Jan 2023 09:50:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CC123858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674726647; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=XUHDR6CdZKNAn6unzekbUkufyq/v6vEx1lRVmTAlz1I=; b=jKI7Wwq04vrncNdtykJ5F9vvI/ROJd1wfoB3t/YCxshaMmoub83+AebpIRvqPoDHpczwJK VFld0kkDZTJD1BFblmk5sy4UQKnljM7z7tMCkJk0jfoOKB0IbvdmTHOzeMNOosQFiySggU m+ER5vpoQYzNz9+4eTo14OD78+kejLc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-VS6EMUz-NDqmKRliNZsfEw-1; Thu, 26 Jan 2023 04:50:46 -0500 X-MC-Unique: VS6EMUz-NDqmKRliNZsfEw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C989F29ABA09 for ; Thu, 26 Jan 2023 09:50:45 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A96351E5 for ; Thu, 26 Jan 2023 09:50:45 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30Q9ogoV605381 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Thu, 26 Jan 2023 10:50:43 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30Q9og1q605380 for gcc-patches@gcc.gnu.org; Thu, 26 Jan 2023 10:50:42 +0100 Date: Thu, 26 Jan 2023 10:50:42 +0100 From: Jakub Jelinek To: gcc-patches@gcc.gnu.org Subject: [committed] openmp, c++: Workaround fold_for_warn ICE on invalid OpenMP collapsed loops [PR108503] Message-ID: Reply-To: Jakub Jelinek MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! My recent change to deduce structured binding vars earlier caused the following invalid testcase to ICE. The problem is that because at cp_convert_omp_range_for when !processing_template_decl we aren't yet ready to finalize the structured bindings (e.g. can't emit there associated code) but need to deduce types of the vars so that we don't get errors if we parse invalid uses of those vars in inner loops of the collapsed construct. This is done by temporarily bumping processing_template_decl around the call to cp_finish_decomp. Unfortunately, as we can't finalize it yet, the types of the vars will be deduced, but their DECL_VALUE_EXPR is not finalized yet and if say fold_for_warn tries to constant expression evaluate them, it recurses on DECL_VALUE_EXPR and ICEs because it sees e.g. ARRAY_REF (with NULL type) on a VAR_DECL with class type. The following patch works around that by temporarily hiding the DECL_VALUE_EXPRs by clearing DECL_HAS_VALUE_EXPR_P in that case during cp_convert_omp_range_for and arranging for cp_finish_omp_range_for to set it back before doing the final cp_finish_decomp. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2023-01-25 Jakub Jelinek PR c++/108503 * parser.cc (cp_convert_omp_range_for): If cp_finish_decomp has been called in !processing_template_decl with processing_template_decl temporarily set, clear DECL_HAS_VALUE_EXPR_P on the vars temporarily. (cp_finish_omp_range_for): And set it back again here. * g++.dg/gomp/pr108503.C: New test. --- gcc/cp/parser.cc.jj 2023-01-25 00:03:42.746684624 +0100 +++ gcc/cp/parser.cc 2023-01-25 13:49:35.128800077 +0100 @@ -43039,6 +43039,7 @@ cp_convert_omp_range_for (tree &this_pre { tree begin, end, range_temp_decl = NULL_TREE; tree iter_type, begin_expr, end_expr; + bool clear_has_value_expr = false; if (processing_template_decl) { @@ -43185,6 +43186,8 @@ cp_convert_omp_range_for (tree &this_pre ++processing_template_decl; cp_finish_decomp (orig_decl, decomp_first_name, decomp_cnt); --processing_template_decl; + if (!processing_template_decl) + clear_has_value_expr = true; } } } @@ -43193,8 +43196,20 @@ cp_convert_omp_range_for (tree &this_pre TREE_VEC_ELT (v, 0) = range_temp_decl; TREE_VEC_ELT (v, 1) = end; TREE_VEC_ELT (v, 2) = orig_decl; + if (clear_has_value_expr) + TREE_PUBLIC (v) = 1; for (unsigned i = 0; i < decomp_cnt; i++) { + if (clear_has_value_expr) + { + /* If cp_finish_decomp was called with processing_template_decl + temporarily set to 1, then decomp names will have deduced + name but the DECL_VALUE_EXPR will be dependent. Hide those + from folding of other loop initializers e.g. for warning + purposes until cp_finish_omp_range_for. */ + gcc_checking_assert (DECL_HAS_VALUE_EXPR_P (decomp_first_name)); + DECL_HAS_VALUE_EXPR_P (decomp_first_name) = 0; + } TREE_VEC_ELT (v, i + 3) = decomp_first_name; decomp_first_name = DECL_CHAIN (decomp_first_name); } @@ -43217,6 +43232,18 @@ cp_finish_omp_range_for (tree orig, tree { decomp_first_name = TREE_VEC_ELT (TREE_CHAIN (orig), 3); decomp_cnt = TREE_VEC_LENGTH (TREE_CHAIN (orig)) - 3; + if (TREE_PUBLIC (TREE_CHAIN (orig))) + { + /* Undo temporary clearing of DECL_HAS_VALUE_EXPR_P done + by cp_convert_omp_range_for above. */ + TREE_PUBLIC (TREE_CHAIN (orig)) = 0; + tree d = decomp_first_name; + for (unsigned i = 0; i < decomp_cnt; i++) + { + DECL_HAS_VALUE_EXPR_P (d) = 1; + d = DECL_CHAIN (d); + } + } cp_maybe_mangle_decomp (decl, decomp_first_name, decomp_cnt); } --- gcc/testsuite/g++.dg/gomp/pr108503.C.jj 2023-01-25 13:52:42.839086391 +0100 +++ gcc/testsuite/g++.dg/gomp/pr108503.C 2023-01-25 13:52:22.901374628 +0100 @@ -0,0 +1,27 @@ +// PR c++/108503 +// { dg-do compile { target c++17 } } +// { dg-additional-options "-Wall" } + +namespace std { + template struct tuple_size; + template struct tuple_element; +} +struct A { + template int get () { return 1; } +}; +template <> struct std::tuple_size { static const int value = 3; }; +template struct std::tuple_element { using type = int; }; + +struct B { + A *begin (); + A *end (); +}; + +void +foo (B a) +{ + #pragma omp for collapse(2) + for (auto [i, j, k] : a) + for (int l = i; l < j; l += k) // { dg-error "initializer expression refers to iteration variable 'i'" } + ; // { dg-error "condition expression refers to iteration variable 'j'" "" { target *-*-* } .-1 } +} // { dg-error "increment expression refers to iteration variable 'k'" "" { target *-*-* } .-2 } Jakub