From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 365B13858D28 for ; Tue, 31 Jan 2023 09:09:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 365B13858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675156149; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dxIbwfIVTPAiaTFlttxKjZqegc36Go8kAnURN0yvPto=; b=LtEqQDmoDGg8oPCdTnapUohlQUvGLpd3VHGPz2ayWQQh66o7vhTScvp8Cc/Z8TzubOpMrp KbZYRtdCOWtJtEAyScp/jZjQcyflrLwJzEBHKGOMPgdn63w8Y8CY2Q2MqikoenrsVXpVo7 0r4M+hMOJ3epax+WvH0IfL8t0ZwXbNk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-348-OFuwpIRIP5qgtu77P5Z34Q-1; Tue, 31 Jan 2023 04:09:07 -0500 X-MC-Unique: OFuwpIRIP5qgtu77P5Z34Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B75D29AA39D; Tue, 31 Jan 2023 09:09:07 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0ED1422F2; Tue, 31 Jan 2023 09:09:06 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 30V994I21042376 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 31 Jan 2023 10:09:04 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 30V993GV1042375; Tue, 31 Jan 2023 10:09:03 +0100 Date: Tue, 31 Jan 2023 10:09:03 +0100 From: Jakub Jelinek To: "H.J. Lu" , Martin =?utf-8?B?TGnFoWth?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libsanitizer: Add __interceptor_sigsetjmp_internal Message-ID: Reply-To: Jakub Jelinek References: <20221216213132.578277-1-hjl.tools@gmail.com> MIME-Version: 1.0 In-Reply-To: <20221216213132.578277-1-hjl.tools@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 16, 2022 at 01:31:32PM -0800, H.J. Lu via Gcc-patches wrote: > Add an internal alias to __interceptor_sigsetjmp to avoid R_X86_64_PC32 > relocation for "jmp __interceptor_sigsetjmp" with old assemblers. I think the patch is ok, but because libsanitizer is just downstream from sanitizers in LLVM, this should be filed in https://reviews.llvm.org/differential/diff/create/ first (with diff -p -U10000 or something similar I think they want there). It can be then cherry-picked into GCC, or at least wait until there is some agreement on what they want or whether they completely reject it and we'd need to carry it as a GCC local patch (in that case it should be in libsanitizer/LOCAL_PATCHES). > PR sanitizer/108106 > * hwasan/hwasan_setjmp_x86_64.S (__interceptor_sigsetjmp): Add > an internal alias, __interceptor_sigsetjmp_internal. > --- > libsanitizer/hwasan/hwasan_setjmp_x86_64.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libsanitizer/hwasan/hwasan_setjmp_x86_64.S b/libsanitizer/hwasan/hwasan_setjmp_x86_64.S > index 7566c1ea0a5..071dcdcf613 100644 > --- a/libsanitizer/hwasan/hwasan_setjmp_x86_64.S > +++ b/libsanitizer/hwasan/hwasan_setjmp_x86_64.S > @@ -37,13 +37,14 @@ __interceptor_setjmp: > CFI_STARTPROC > _CET_ENDBR > xorl %esi, %esi > - jmp __interceptor_sigsetjmp > + jmp __interceptor_sigsetjmp_internal > CFI_ENDPROC > ASM_SIZE(__interceptor_setjmp) > > .global __interceptor_sigsetjmp > ASM_TYPE_FUNCTION(__interceptor_sigsetjmp) > __interceptor_sigsetjmp: > +__interceptor_sigsetjmp_internal: > CFI_STARTPROC > _CET_ENDBR > Jakub