From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 759EC3858D39 for ; Wed, 1 Feb 2023 09:09:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 759EC3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675242555; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=EJMo/+jVqq4KEXzBb7P9mzWSSih52M617jDH8QLX3Hs=; b=dDg1MvkZH06aSCxPb6+4XTWxltguwv0i+umCcwcXeA5vuV8+5JNKjaKflK0C2MyE/Z17Ur tGtCnUIcQR3bf7WQ4vUlyXLUlQbb7b6khMoXA76JXrgzq5o+Y1ROXwws1h98Vp2rr1RFr4 15nTIRuJuPWbwyw4/HhUyYmn1krA8r4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-eRuvtOe3Oc2FCfnU6JpgzA-1; Wed, 01 Feb 2023 04:09:13 -0500 X-MC-Unique: eRuvtOe3Oc2FCfnU6JpgzA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 38B79183B3C0; Wed, 1 Feb 2023 09:09:13 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB6BA2026D68; Wed, 1 Feb 2023 09:09:12 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31199Ai63209373 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 1 Feb 2023 10:09:10 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 311999EG3209372; Wed, 1 Feb 2023 10:09:09 +0100 Date: Wed, 1 Feb 2023 10:09:09 +0100 From: Jakub Jelinek To: Fangrui Song , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] x86: Use DW_EH_PE_indirect|DW_EH_PE_pcrel encodings for -fno-pic code Message-ID: Reply-To: Jakub Jelinek References: <20230201073859.3920910-1-maskray@google.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 01, 2023 at 10:01:36AM +0100, Jakub Jelinek via Gcc-patches wrote: > And, while I can understand the rationale for global cases > (though am not sure I agree, as currently the user can choose > by using -mno-direct-extern-access or not using it, the above change > disallows the choice), for !global I miss the point altogether. > In non-PIC (and non-PECOFF maybe, don't know that format well) > code if code references a local symbol, it will never generate > a copy relocation and so DW_EH_PE_udata4 could be just fine and cheaper > to handle on the consumer sides. Plus, e.g. for the typeinfo references, if using the default -mdirect-extern-access and RTTI is used, there will be copy relocations anyway and so the .eh_frame growth will be just waste of .got space. Jakub