From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id DDDDD396DC14 for ; Thu, 22 Jul 2021 04:55:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDDDD396DC14 Received: by mail-pl1-x62a.google.com with SMTP id h1so3101483plf.6 for ; Wed, 21 Jul 2021 21:55:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sUpGD4lPrA9nt/0Z++0BDLH+SqGxlE0OhWtE47WWRXQ=; b=ABs69PecB+mxWiG2ewoOT2gpBONZEpZJuH1jy+GHN6JKEt8dxoxpl3MQFAKc9xhQRh IZBGwCLrfScsbcPMV37ipXsht+lz4hciQNO/n7mOdi7lFr+qPjxlDgfFBwymw2Ubjn80 qKYemgYavnPYMcF2CHuX/xQOpDmYP4dLQonC2xkTrECTBanYZZ4NshTNV7mGxPzKyjy4 UW5ljiyxdWsshGyuQDiyKQfin1Rl2nwbIp6EqIEPSa0sTNqibBuTA3R7XfCviF7QouWB oTLEGmSQuaXbdCC5yVcMZ9e30yTgT4aNUUrx4k+MBq6XZGYgZ6ct8pWLjNcaYJI8Rrbz wXVA== X-Gm-Message-State: AOAM531HDoToN+E1kqdefWYTfPUClKbW0AAR0iYqutivoMWjNSG085k3 +p9wtRYsRYzQsMS/TT/IuR+5hR/UKtnpXg== X-Google-Smtp-Source: ABdhPJzSKc/aaY6DDZV/4izbt1DhDIQixsVUbp9PMM94CcvOpigK9+jrAktNcf7uvKFLBvavor3l1g== X-Received: by 2002:a17:90b:1e10:: with SMTP id pg16mr33884197pjb.87.1626929748489; Wed, 21 Jul 2021 21:55:48 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id s20sm1470783pji.19.2021.07.21.21.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 21:55:47 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 8F597114001C; Thu, 22 Jul 2021 14:25:44 +0930 (ACST) Date: Thu, 22 Jul 2021 14:25:44 +0930 From: Alan Modra To: Richard Biener , gcc-patches@gcc.gnu.org Cc: David Edelsohn , Segher Boessenkool , Bill Schmidt , Peter Bergner Subject: Re: [POWER10] __morestack calls from pcrel code Message-ID: References: <87fswz6rsp.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-3033.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2021 04:55:51 -0000 On Wed, Jul 21, 2021 at 08:59:04AM -0400, David Edelsohn wrote: > On Wed, Jul 21, 2021 at 4:29 AM Alan Modra wrote: > > > > On Wed, Jul 14, 2021 at 08:24:16PM -0400, David Edelsohn wrote: > > > > > > * config/rs6000/morestack.S (R2_SAVE): Define. > > > > > > (__morestack): Save and restore r2. Set up r2 for called > > > > > > functions. > > > > > > This patch is okay. > > > > Thanks David, the patch is needed on gcc-11 and gcc-10 too. > > OK for the branches too? > > Backports are fine, but I believe that Richi is planning to cut GCC 11 > RC today, so you really should check with him about a backport at the > last minute. Hi Richard, Is this patch OK at this late stage for the gcc-11 branch? https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573978.html The impacts of the bug are segfaults and other undesirable behaviour with Go (or more generally -fsplit-stack) on power10 when libgcc is not power10 pcrel. A non-pcrel libgcc is very likely how distros will ship gcc. -- Alan Modra Australia Development Lab, IBM