From: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl.
Date: Tue, 31 Aug 2021 02:03:26 +0300 [thread overview]
Message-ID: <YS1jvqJ7qQuVVfFg@glebfm.cloud.tilaa.com> (raw)
In-Reply-To: <eafb9301-207e-2f79-24ca-83a9842c04fa@suse.cz>
On Mon, Aug 30, 2021 at 10:13:21AM +0200, Martin Liška wrote:
> On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote:
> > Hi,
> >
> > On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote:
> >> Pushed as obvious, the original change was done
> >> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a.
> >>
> >> Martin
> >>
> >> ChangeLog:
> >>
> >> * Makefile.tpl: The change was done Makefile.in which
> >> is generated file.
> >> ---
> >> Makefile.tpl | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Makefile.tpl b/Makefile.tpl
> >> index 3b88f351d5b..6e0337fb48f 100644
> >> --- a/Makefile.tpl
> >> +++ b/Makefile.tpl
> >> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS)
> >> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS))
> >> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS))
> >>
> >> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use
> >> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs
> >
> > Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS
> > instead?
>
> No.
>
> > I suppose this flag doesn't mean anything without
> > -fprofile-generate, which is passed through STAGEprofile_CFLAGS.
>
> The flag -fprofile-reproducible is used when we use a collected profile, so it works
> *only* with -fprofile-use flag.
Thank you for the answer, now I see how it works.
I think that it means that the documentation is rather misleading about
this flag:
'-fprofile-reproducible=[multithreaded|parallel-runs|serial]'
Control level of reproducibility of profile gathered by
'-fprofile-generate'. [...]
It convinced me that this flag changes the way the code is instrumented
for profile generation. The rest of it convinced me even more, actually.
> Thanks for heads up!
> Cheers,
> Martin
>
> >
> > Thanks,
> >
--
glebfm
next prev parent reply other threads:[~2021-08-30 23:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 15:19 Martin Liška
2021-08-27 17:45 ` Gleb Fotengauer-Malinovskiy
2021-08-30 8:13 ` Martin Liška
2021-08-30 23:03 ` Gleb Fotengauer-Malinovskiy [this message]
2021-08-31 6:54 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS1jvqJ7qQuVVfFg@glebfm.cloud.tilaa.com \
--to=glebfm@altlinux.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).