From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 88D613858D34 for ; Mon, 30 Aug 2021 23:04:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88D613858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from imap.altlinux.org (imap.altlinux.org [194.107.17.38]) by vmicros1.altlinux.org (Postfix) with ESMTP id 5845F72C8FB; Tue, 31 Aug 2021 02:04:32 +0300 (MSK) Received: from glebfm.cloud.tilaa.com (glebfm.cloud.tilaa.com [84.22.98.219]) by imap.altlinux.org (Postfix) with ESMTPSA id 23EE24A46F2; Tue, 31 Aug 2021 02:04:32 +0300 (MSK) Date: Tue, 31 Aug 2021 02:03:26 +0300 From: Gleb Fotengauer-Malinovskiy To: Martin =?utf-8?B?TGnFoWth?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 23:04:44 -0000 On Mon, Aug 30, 2021 at 10:13:21AM +0200, Martin Liška wrote: > On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote: > > Hi, > > > > On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: > >> Pushed as obvious, the original change was done > >> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. > >> > >> Martin > >> > >> ChangeLog: > >> > >> * Makefile.tpl: The change was done Makefile.in which > >> is generated file. > >> --- > >> Makefile.tpl | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/Makefile.tpl b/Makefile.tpl > >> index 3b88f351d5b..6e0337fb48f 100644 > >> --- a/Makefile.tpl > >> +++ b/Makefile.tpl > >> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) > >> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) > >> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) > >> > >> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use > >> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs > > > > Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS > > instead? > > No. > > > I suppose this flag doesn't mean anything without > > -fprofile-generate, which is passed through STAGEprofile_CFLAGS. > > The flag -fprofile-reproducible is used when we use a collected profile, so it works > *only* with -fprofile-use flag. Thank you for the answer, now I see how it works. I think that it means that the documentation is rather misleading about this flag: '-fprofile-reproducible=[multithreaded|parallel-runs|serial]' Control level of reproducibility of profile gathered by '-fprofile-generate'. [...] It convinced me that this flag changes the way the code is instrumented for profile generation. The rest of it convinced me even more, actually. > Thanks for heads up! > Cheers, > Martin > > > > > Thanks, > > -- glebfm