From: Jonathan Wakely <jwakely@redhat.com>
To: liuke.gehry@bytedance.com
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++-v3: Optimize 'to_string<int>' with numeric_limits instead of __to_chars_len
Date: Tue, 14 Sep 2021 17:56:57 +0100 [thread overview]
Message-ID: <YUDUWZA0fA+zCfrW@redhat.com> (raw)
In-Reply-To: <CALf+iisuf_fs-PEhF-dCGa5u+ibQds5BVFwWZXMNYo1d_qDzVw@mail.gmail.com>
Please CC libstdc++ patches to the libstdc++ list, or they won't get
reviewed (because I don't subscribe to gcc-patches).
GCC 5 does implement SSO but it's only used conditionally. Your patch
uses numeric_limits unconditionally, which will result in
over-allocation for COW strings.
There also seems to be a syntax error in the unsigned overload, was
this patch tested?
Minor: the "component" tag in the subject should be just "libstdc++:"
without the "-v3" part.
prev parent reply other threads:[~2021-09-14 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:47 刘可
2021-09-14 16:56 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUDUWZA0fA+zCfrW@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=liuke.gehry@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).