public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Nicholas Nethercote <n.nethercote@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Eduard-Mihai Burtescu <eddyb@lyken.rs>
Subject: Re: [PATCH] libiberty rust-demangle, ignore .suffix
Date: Thu, 2 Dec 2021 23:54:24 +0100	[thread overview]
Message-ID: <YalOoCDTkfZ2N10v@wildebeest.org> (raw)
In-Reply-To: <CAEXw-AAz9xZDi2TTRdb9TzV_ONX3JZMNdzVFjsj7jR9gfz4QPA@mail.gmail.com>

Hi,

On Fri, Dec 03, 2021 at 06:58:36AM +1100, Nicholas Nethercote wrote:
> On Fri, 3 Dec 2021 at 04:17, Mark Wielaard <mark@klomp.org> wrote:
> >
> >         * rust-demangle.c (rust_demangle_callback): Ignore everything
> >         after '.' char in sym for v0.
> >
> 
> I just applied this change to Valgrind's copy of rust-demangle.c and I can
> confirm that it works -- the symbols that were failing to be demangled are
> now demangled.

Thanks for testing.

> > +      /* Rust v0 symbols can have '.' suffixes, ignore those.  */
> > +      if (rdm.version == 0 && *p == '.')
> > +       break;
> >
> 
> Note that the indent on the `break` is 1 char, it should be 2.

Oops. That is actually because I used a tab for indentation, but this
file doesn't use tabs. Fixed in my local copy
https://code.wildebeest.org/git/user/mjw/gcc/commit/?h=rust-demangle-suffix
Will push with that fix if approved.

Thanks,

Mark


      reply	other threads:[~2021-12-02 22:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 17:17 Mark Wielaard
2021-12-02 17:35 ` Eduard-Mihai Burtescu
2021-12-02 22:07   ` Mark Wielaard
2021-12-02 23:14     ` Eduard-Mihai Burtescu
2021-12-07 19:16       ` Mark Wielaard
2021-12-20 11:50         ` Eduard-Mihai Burtescu
2022-01-16  0:27           ` Mark Wielaard
2021-12-02 19:58 ` Nicholas Nethercote
2021-12-02 22:54   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YalOoCDTkfZ2N10v@wildebeest.org \
    --to=mark@klomp.org \
    --cc=eddyb@lyken.rs \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=n.nethercote@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).