From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6ED7B3858014 for ; Fri, 10 Dec 2021 16:02:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6ED7B3858014 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-78-agvI94LFN6eMYzzVraG7MA-1; Fri, 10 Dec 2021 11:02:01 -0500 X-MC-Unique: agvI94LFN6eMYzzVraG7MA-1 Received: by mail-qt1-f200.google.com with SMTP id h20-20020ac85e14000000b002b2e9555bb1so14552923qtx.3 for ; Fri, 10 Dec 2021 08:02:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KQiGYloI3u+d33vVUeKmq+mfp6OXA/gIAC5WfTRj8JU=; b=RZqQ/OnQh0DF6rKs8XZjlTBlSpIM+wpQYjzIQsZOFbARjxQrsr/aPRlFRS1DeVImS4 au6j9t80EZNE1ESYyc0LTuxgRCIE7j4yI0E1IvaQmD0TJ/qtwRiNRE7k/VexpVay5nkU G/kmTYLzPsII2V/NP4v0kkH1mV2xWs5URyKXjoMDCOLxXKtkhVaNITHJa8AjROrqRa6r o1bvp9GFY2j8uh7942nWdKJSsLoEaZTjjcUvt5xkdA1PaT9/r/00fj6x5bhIkXpr/dXt wEKTrmcTDxIfpkuwtlLVguXtZCLMRgdD84FkCW0QF29cRS+T/d3FwemSlipVTyLg9n/U BXpA== X-Gm-Message-State: AOAM530rExzpu2QXdFC4QVlA0UOusAHrbn8lO1uhMBcuiUVKoCcrDyO1 6hXj4ZznjZkGfiYcA4LI5xn8qOfgXX+0TCmh+437u0UVWmzBwEhHxhftyl0mKe8VNXdqxS5v7ra eJFYgxbv8ou/btqi+Iw== X-Received: by 2002:a05:622a:178c:: with SMTP id s12mr28024542qtk.156.1639152121025; Fri, 10 Dec 2021 08:02:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxlh2fr9utic6H7dIUOiufB+vkb8IRsUtYCMJISRpmsi2H+QiK+UFti3NPabsRM3Oge2lSEg== X-Received: by 2002:a05:622a:178c:: with SMTP id s12mr28024511qtk.156.1639152120672; Fri, 10 Dec 2021 08:02:00 -0800 (PST) Received: from redhat.com ([2601:184:4780:4310::aac2]) by smtp.gmail.com with ESMTPSA id d17sm1998081qtx.96.2021.12.10.08.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 08:01:59 -0800 (PST) Date: Fri, 10 Dec 2021 11:01:58 -0500 From: Marek Polacek To: Patrick Palka Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] c++: remove COMPOUND_EXPR_OVERLOADED flag Message-ID: References: <20211210154800.2903317-1-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211210154800.2903317-1-ppalka@redhat.com> User-Agent: Mutt/2.1.3 (2021-09-10) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 16:02:07 -0000 On Fri, Dec 10, 2021 at 10:48:00AM -0500, Patrick Palka via Gcc-patches wrote: > This flag is never set because non-dependent COMPOUND_EXPRs are fully > resolved into a CALL_EXPR at template definition time (in > build_x_compound_expr) ever since r6-5772. > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for > trunk? LGTM. > gcc/cp/ChangeLog: > > * cp-tree.h (COMPOUND_EXPR_OVERLOADED): Remove. > * pt.c (build_non_dependent_expr): Don't inspect this flag. > * tree.c (build_min_non_dep): Don't set this flag. > --- > gcc/cp/cp-tree.h | 6 ------ > gcc/cp/pt.c | 3 +-- > gcc/cp/tree.c | 5 ----- > 3 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/gcc/cp/cp-tree.h b/gcc/cp/cp-tree.h > index b1c3bc5ed1f..e4330fb1f8b 100644 > --- a/gcc/cp/cp-tree.h > +++ b/gcc/cp/cp-tree.h > @@ -404,7 +404,6 @@ extern GTY(()) tree cp_global_trees[CPTI_MAX]; > NEW_EXPR_USE_GLOBAL (in NEW_EXPR). > COND_EXPR_IS_VEC_DELETE (in COND_EXPR). > DELETE_EXPR_USE_GLOBAL (in DELETE_EXPR). > - COMPOUND_EXPR_OVERLOADED (in COMPOUND_EXPR). > CLEANUP_P (in TRY_BLOCK) > AGGR_INIT_VIA_CTOR_P (in AGGR_INIT_EXPR) > PTRMEM_OK_P (in ADDR_EXPR, OFFSET_REF, SCOPE_REF) > @@ -4015,11 +4014,6 @@ struct GTY(()) lang_decl { > #define CALL_OR_AGGR_INIT_CHECK(NODE) \ > TREE_CHECK2 ((NODE), CALL_EXPR, AGGR_INIT_EXPR) > > -/* Indicates that this is a non-dependent COMPOUND_EXPR which will > - resolve to a function call. */ > -#define COMPOUND_EXPR_OVERLOADED(NODE) \ > - TREE_LANG_FLAG_0 (COMPOUND_EXPR_CHECK (NODE)) > - > /* In a CALL_EXPR appearing in a template, true if Koenig lookup > should be performed at instantiation time. */ > #define KOENIG_LOOKUP_P(NODE) TREE_LANG_FLAG_0 (CALL_EXPR_CHECK (NODE)) > diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c > index 9834baf34db..cbdb4b566aa 100644 > --- a/gcc/cp/pt.c > +++ b/gcc/cp/pt.c > @@ -28373,8 +28373,7 @@ build_non_dependent_expr (tree expr) > ? build_non_dependent_expr (TREE_OPERAND (expr, 1)) > : build_non_dependent_expr (TREE_OPERAND (expr, 0))), > build_non_dependent_expr (TREE_OPERAND (expr, 2))); > - if (TREE_CODE (expr) == COMPOUND_EXPR > - && !COMPOUND_EXPR_OVERLOADED (expr)) > + if (TREE_CODE (expr) == COMPOUND_EXPR) > return build2 (COMPOUND_EXPR, > TREE_TYPE (expr), > TREE_OPERAND (expr, 0), > diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c > index 52c56831f98..f6f7927f293 100644 > --- a/gcc/cp/tree.c > +++ b/gcc/cp/tree.c > @@ -3577,11 +3577,6 @@ build_min_non_dep (enum tree_code code, tree non_dep, ...) > for (i = 0; i < length; i++) > TREE_OPERAND (t, i) = va_arg (p, tree); > > - if (code == COMPOUND_EXPR && TREE_CODE (non_dep) != COMPOUND_EXPR) > - /* This should not be considered a COMPOUND_EXPR, because it > - resolves to an overload. */ > - COMPOUND_EXPR_OVERLOADED (t) = 1; > - > va_end (p); > return convert_from_reference (t); > } > -- > 2.34.1.75.gabe6bb3905 > Marek