public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@kam.mff.cuni.cz>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] internal_error - do not use leading capital letter
Date: Thu, 27 Jan 2022 13:45:45 +0100	[thread overview]
Message-ID: <YfKT+X0XJatmWoEN@kam.mff.cuni.cz> (raw)
In-Reply-To: <d246cea8-bcca-7cab-477d-ca5594c937d4@suse.cz>

> That's follow up patch based on the discussion with Jakub.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
> 	* config/rs6000/host-darwin.cc (segv_crash_handler):
> 	Do not use leading capital letter.
> 	(segv_handler): Likewise.
> 	* ipa-sra.cc (verify_splitting_accesses): Likewise.
> 	* varasm.cc (get_section): Likewise.
> 
> gcc/d/ChangeLog:
> 
> 	* decl.cc (d_finish_decl): Do not use leading capital letter.
> ---
>  gcc/config/rs6000/host-darwin.cc | 4 ++--
>  gcc/d/decl.cc                    | 2 +-
>  gcc/ipa-sra.cc                   | 4 ++--
>  gcc/varasm.cc                    | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc
> index 541f7e1c81c..efb1965004e 100644
> --- a/gcc/config/rs6000/host-darwin.cc
> +++ b/gcc/config/rs6000/host-darwin.cc
> @@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED,
>    fprintf (stderr, "[address=%08lx pc=%08x]\n",
>  	   uc->uc_mcontext->MC_FLD(es).MC_FLD(dar),
>  	   uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0));
> -  internal_error ("Segmentation Fault");
> +  internal_error ("egmentation fault");
segmentation or perhaps eggmentation? :)

Honza

  reply	other threads:[~2022-01-27 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 12:40 Martin Liška
2022-01-27 12:45 ` Jan Hubicka [this message]
2022-01-27 16:25 ` Iain Buclaw
2022-01-28 14:59 ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfKT+X0XJatmWoEN@kam.mff.cuni.cz \
    --to=hubicka@kam.mff.cuni.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).