From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 5496D3858D1E for ; Wed, 9 Feb 2022 19:00:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5496D3858D1E Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 219HXTcc024681; Wed, 9 Feb 2022 19:00:09 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e4fww54ur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 19:00:09 +0000 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 219Ipq1x006954; Wed, 9 Feb 2022 19:00:09 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 3e4fww54u3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 19:00:09 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 219IvIHL002760; Wed, 9 Feb 2022 19:00:08 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma02dal.us.ibm.com with ESMTP id 3e3gq0cyk1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Feb 2022 19:00:08 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 219J06qm21103076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Feb 2022 19:00:06 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A26F86A071; Wed, 9 Feb 2022 19:00:06 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10BA66A05A; Wed, 9 Feb 2022 19:00:06 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.77.136.59]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTPS; Wed, 9 Feb 2022 19:00:05 +0000 (GMT) Date: Wed, 9 Feb 2022 14:00:04 -0500 From: Michael Meissner To: "Kewen.Lin" Cc: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Bill Schmidt , Peter Bergner , Will Schmidt Subject: Re: [PATCH] PR target/102059 Fix inline of target specific functions Message-ID: Mail-Followup-To: Michael Meissner , "Kewen.Lin" , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn , Bill Schmidt , Peter Bergner , Will Schmidt References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 1Fc_n3hLweeiCk9aVLnP5boMSKn8jeD5 X-Proofpoint-GUID: LUEi4Y6LJPDe_MbIqtFlb0XT9cF2tbY6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-09_09,2022-02-09_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202090098 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 19:00:11 -0000 On Wed, Feb 09, 2022 at 04:56:13PM +0800, Kewen.Lin wrote: > Hi Michael, > > on 2022/2/9 上午11:27, Michael Meissner via Gcc-patches wrote: > > Reset -mpower8-fusion for power9 inlining power8 functions, PR 102059. > > > > This patch is an attempt to make a much simpler patch to fix PR target/102059 > > than the previous patch. > > > > It just fixes the issue that if a function is specifically declared as a power8 > > function, you can't inline in functions that are specified with power9 or > > power10 options. > > > > The issue is -mpower8-fusion is cleared when you use -mcpu=power9 or > > -mcpu=power10. When I wrote the code for controlling which function can inline > > other functions, -mpower8-fusion was set for -mcpu=power9 (-mcpu=power10 was > > not an option at that time). This patch fixes this particular problem. > > > > Perhaps -mpower8-fusion should go away in the GCC 13 time frame. This patch > > just goes in and resets the fusion bit for testing inlines. > > > > I have built a bootstrapped little endian compiler on power9 and the tests had > > no regressions. > > > > I have built a bootstrapped big endian compiler on power8 and I tested both > > 32-bit and 64-bit builds, and there were no regressions. > > > > Can I install this into the trunk and back port it into GCC 11 after a burn-in > > period? > > > > Thanks for the patch! I guess we also need this for GCC 10 as: Gcc 10 backport is doable once it is installed in the trunk. Since a lot of my work is on IEEE 128-bit or Power10, I don't always think of GCC 10 backports, but in this case, the patch is rather simple. Thanks for the reminder. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com