From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C86433858D39 for ; Wed, 2 Mar 2022 09:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C86433858D39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-WBpQLuhIMSywGtOqXz2R6A-1; Wed, 02 Mar 2022 04:38:09 -0500 X-MC-Unique: WBpQLuhIMSywGtOqXz2R6A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78DB21854E27; Wed, 2 Mar 2022 09:38:08 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23D5A8317C; Wed, 2 Mar 2022 09:38:07 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 2229c51J964232 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 2 Mar 2022 10:38:05 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 2229c4DN964231; Wed, 2 Mar 2022 10:38:04 +0100 Date: Wed, 2 Mar 2022 10:38:04 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details Message-ID: Reply-To: Jakub Jelinek MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 09:38:12 -0000 Hi! When debugging the PR104589 issue, I've run into a problem that goto_locus doesn't show up in the logs, so it wasn't clear if the bug hasn't been introduced far earlier just by divergence in goto_locus of some edge. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk, or for GCC 13? 2022-03-02 Jakub Jelinek * cfg.cc (dump_edge_info): Dump goto_locus if present. --- gcc/cfg.cc.jj 2022-01-18 11:58:58.944991171 +0100 +++ gcc/cfg.cc 2022-03-01 15:33:08.170217978 +0100 @@ -555,6 +555,10 @@ dump_edge_info (FILE *file, edge e, dump fputc (')', file); } + + if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION) + fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus), + LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus)); } DEBUG_FUNCTION void Jakub