From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A14B33858402 for ; Thu, 24 Feb 2022 10:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A14B33858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-gTgfO7UvPZK0eI6bKe6SRw-1; Thu, 24 Feb 2022 05:09:55 -0500 X-MC-Unique: gTgfO7UvPZK0eI6bKe6SRw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DA05824FA7; Thu, 24 Feb 2022 10:09:54 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A10E66FEE2; Thu, 24 Feb 2022 10:09:53 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 21OA9os8023903 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 24 Feb 2022 11:09:50 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 21OA9ndQ023902; Thu, 24 Feb 2022 11:09:49 +0100 Date: Thu, 24 Feb 2022 11:09:48 +0100 From: Jakub Jelinek To: Tom de Vries Cc: Tobias Burnus , gcc-patches Subject: Re: [PATCH][libgomp, testsuite, nvptx] Add libgomp.c/declare-variant-3-sm*.c Message-ID: Reply-To: Jakub Jelinek References: <6b0f4fe5-06d4-5ede-5bd1-a53ed82f6d36@suse.de> <221e5215-3b8b-fa9f-4e7b-2faa86b8b991@codesourcery.com> <71e9c008-7ad1-c24f-76eb-6a03180525c4@suse.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 10:10:00 -0000 On Thu, Feb 24, 2022 at 11:01:22AM +0100, Tom de Vries wrote: > [ was: Re: [Patch] nvptx: Add -mptx=6.0 + -misa=sm_70 ] > > On 2/24/22 09:29, Tom de Vries wrote: > > I'll try to submit a patch with one or more test-cases. > > Hi, > > These test-cases exercise the omp declare variant construct using the > available nvptx isas. > > OK for trunk? > > Thanks, > - Tom > [libgomp, testsuite, nvptx] Add libgomp.c/declare-variant-3-sm*.c > > Add openmp test-cases that test the omp declare variant construct: > ... > #pragma omp declare variant (f30) match (device={isa("sm_30")}) > ... > using the available nvptx isas. > > On a Pascal board GT 1030 with sm_61, we have these unsupported: > ... > UNSUPPORTED: libgomp.c/declare-variant-3-sm70.c > UNSUPPORTED: libgomp.c/declare-variant-3-sm75.c > UNSUPPORTED: libgomp.c/declare-variant-3-sm80.c > ... > and on a Turing board T400 with sm_75, we have this only this one: > ... > UNSUPPORTED: libgomp.c/declare-variant-3-sm80.c > ... > > Tested on x86_64 with nvptx accelerator. I think testing it through dg-do link tests with -fdump-tree-optimized or so would be better, you wouldn't need access to actual hardware level and checking in the dump what function is actually called for each case is easy. Jakub