public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Krebbel <krebbel@linux.ibm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] s390: Fix up *cmp_and_trap_unsigned_int<mode> constraints [PR104775]
Date: Sun, 6 Mar 2022 10:15:25 +0100	[thread overview]
Message-ID: <YiR7rfGqLyInZvCL@tucnak> (raw)
In-Reply-To: <YiMgdlKRkRVbpo+I@tucnak>

On Sat, Mar 05, 2022 at 09:33:58AM +0100, Jakub Jelinek via Gcc-patches wrote:
> Hi!
> 
> The following testcase fails to assemble due to clgte %r6,0(%r1,%r10)
> insn not being accepted by assembler.
> My rough understanding is that in the RSY-b insn format the spot
> in other formats used for index registers is used instead for M3 what
> kind of comparison it is, so this patch follows what other similar
> instructions use for constraint (i.e. one without index register).
> 
> Bootstrapped on s390x-linux, regtest there still pending, ok for
> trunk if it passes it?

Regression testing passed too.

> 2022-03-05  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR target/104775
> 	* config/s390/s390.md (*cmp_and_trap_unsigned_int<mode>): Use
> 	S constraint instead of T in the last alternative.
> 
> 	* gcc.target/s390/pr104775.c: New test.

	Jakub


  reply	other threads:[~2022-03-06  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05  8:33 Jakub Jelinek
2022-03-06  9:15 ` Jakub Jelinek [this message]
2022-03-07 10:10 ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiR7rfGqLyInZvCL@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=krebbel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).