From: Michael Meissner <meissner@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: will schmidt <will_schmidt@vnet.ibm.com>,
Michael Meissner <meissner@linux.ibm.com>,
gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH, V2] Eliminate power8 fusion options, use power8 tuning, PR target/102059
Date: Thu, 10 Mar 2022 15:46:09 -0500 [thread overview]
Message-ID: <YipjkU3gzL4YT0LQ@toto.the-meissners.org> (raw)
In-Reply-To: <20220310194936.GX614@gate.crashing.org>
On Thu, Mar 10, 2022 at 01:49:36PM -0600, Segher Boessenkool wrote:
> On Thu, Mar 10, 2022 at 10:44:52AM -0600, will schmidt wrote:
> > On Wed, 2022-03-09 at 22:49 -0500, Michael Meissner wrote:
> > > --- a/gcc/config/rs6000/rs6000-cpus.def
> > > +++ b/gcc/config/rs6000/rs6000-cpus.def
> > > @@ -43,9 +43,7 @@
> > > | OPTION_MASK_ALTIVEC \
> > > | OPTION_MASK_VSX)
> > >
> > > -/* For now, don't provide an embedded version of ISA 2.07. Do not set power8
> > > - fusion here, instead set it in rs6000.cc if we are tuning for a power8
> > > - system. */
> > > +/* For now, don't provide an embedded version of ISA 2.07. */
> >
> > ok. (as far as removing the comment, I'm not clear what the remaining
> > comment is telling me, but thats outside of the scope of this patch).
>
> It is saying there is nothing that implements Book III-E of ISA 2.07
> (nothing in GCC, but no actual CPU either). Or Category: Embedded even
> maybe :-)
>
> It could be clearer perhaps, or just be removed completely; it might
> have been useful historically, but it isn't anymore really.
Other than possibly removing the comment, are there other things about the
patch that need to be done?
--
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: meissner@linux.ibm.com
prev parent reply other threads:[~2022-03-10 20:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 3:49 Michael Meissner
2022-03-10 16:44 ` will schmidt
2022-03-10 19:49 ` Segher Boessenkool
2022-03-10 20:00 ` will schmidt
2022-03-10 20:34 ` Michael Meissner
2022-03-10 20:46 ` Michael Meissner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YipjkU3gzL4YT0LQ@toto.the-meissners.org \
--to=meissner@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).