From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 5C0013858D39 for ; Thu, 10 Mar 2022 20:46:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C0013858D39 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22AKVCkL008699; Thu, 10 Mar 2022 20:46:16 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3eqmx5n1nj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Mar 2022 20:46:16 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22AKVECn008862; Thu, 10 Mar 2022 20:46:15 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3eqmx5n1n7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Mar 2022 20:46:15 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22AKgfZi024382; Thu, 10 Mar 2022 20:46:14 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03wdc.us.ibm.com with ESMTP id 3epwg69jsk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Mar 2022 20:46:14 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22AKkCOi28705144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Mar 2022 20:46:12 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1FCDBE061; Thu, 10 Mar 2022 20:46:12 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1E31BE069; Thu, 10 Mar 2022 20:46:11 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.77.136.59]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 10 Mar 2022 20:46:11 +0000 (GMT) Date: Thu, 10 Mar 2022 15:46:09 -0500 From: Michael Meissner To: Segher Boessenkool Cc: will schmidt , Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner Subject: Re: [PATCH, V2] Eliminate power8 fusion options, use power8 tuning, PR target/102059 Message-ID: Mail-Followup-To: Michael Meissner , Segher Boessenkool , will schmidt , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner References: <3afaaa1a115e2546b2e19467a4c7973c4ddcd4f7.camel@vnet.ibm.com> <20220310194936.GX614@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220310194936.GX614@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: sQ4ZJ6CCN-XiqIWW3Ih0eGwcuGNfQiNw X-Proofpoint-ORIG-GUID: 2vopp0ad6JUWtDoRHRhVUWK9AoVxX3_W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-10_09,2022-03-09_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 mlxlogscore=921 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203100103 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 20:46:18 -0000 On Thu, Mar 10, 2022 at 01:49:36PM -0600, Segher Boessenkool wrote: > On Thu, Mar 10, 2022 at 10:44:52AM -0600, will schmidt wrote: > > On Wed, 2022-03-09 at 22:49 -0500, Michael Meissner wrote: > > > --- a/gcc/config/rs6000/rs6000-cpus.def > > > +++ b/gcc/config/rs6000/rs6000-cpus.def > > > @@ -43,9 +43,7 @@ > > > | OPTION_MASK_ALTIVEC \ > > > | OPTION_MASK_VSX) > > > > > > -/* For now, don't provide an embedded version of ISA 2.07. Do not set power8 > > > - fusion here, instead set it in rs6000.cc if we are tuning for a power8 > > > - system. */ > > > +/* For now, don't provide an embedded version of ISA 2.07. */ > > > > ok. (as far as removing the comment, I'm not clear what the remaining > > comment is telling me, but thats outside of the scope of this patch). > > It is saying there is nothing that implements Book III-E of ISA 2.07 > (nothing in GCC, but no actual CPU either). Or Category: Embedded even > maybe :-) > > It could be clearer perhaps, or just be removed completely; it might > have been useful historically, but it isn't anymore really. Other than possibly removing the comment, are there other things about the patch that need to be done? -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com