public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] predcom: Fix up component::component [PR105056]
Date: Sat, 26 Mar 2022 09:46:03 +0100	[thread overview]
Message-ID: <Yj7SthxrXRlW3IBn@tucnak> (raw)

Hi!

The recent change didn't initialize comp_step while previously we used
XCNEW to allocate it.

I think RS_ANY is better than RS_INTERNAL (== 0) as the default.

Bootstrappedd/regtested on x86_64-linux and i686-linux, ok for trunk?

2022-03-26  Jakub Jelinek  <jakub@redhat.com>

	PR tree-optimization/105056
	* tree-predcom.cc (component::component): Initialize also comp_step.

--- gcc/tree-predcom.cc.jj	2022-03-24 12:23:11.000000000 +0100
+++ gcc/tree-predcom.cc	2022-03-25 17:50:09.238282600 +0100
@@ -367,7 +367,8 @@ enum ref_step_type
 
 struct component
 {
-  component (bool es) : eliminate_store_p (es), next (NULL) {}
+  component (bool es) : comp_step (RS_ANY), eliminate_store_p (es),
+    next (NULL) {}
 
   /* The references in the component.  */
   auto_vec<dref> refs;

	Jakub


             reply	other threads:[~2022-03-28  7:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26  8:46 Jakub Jelinek [this message]
2022-03-28  7:47 ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yj7SthxrXRlW3IBn@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).