From: Jakub Jelinek <jakub@redhat.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@gcc.gnu.org>,
YunQiang Su <yunqiang.su@cipunited.com>
Subject: Re: [PATCH v2] mips: Fix C++14 vs. C++17 ABI incompatibility on mips64
Date: Wed, 6 Apr 2022 16:34:46 +0200 [thread overview]
Message-ID: <Yk2lBlEZQ5CDETob@tucnak> (raw)
In-Reply-To: <5a7f486da7458d9606e0ebbd87a097a3560bbb2b.camel@mengyan1223.wang>
On Wed, Apr 06, 2022 at 09:44:33PM +0800, Xi Ruoyao wrote:
> @@ -6527,6 +6554,27 @@ mips_function_value_1 (const_tree valtype, const_tree fn_decl_or_type,
> if (has_cxx_zero_width_bf)
> use_fpr = 0;
>
> + if (TARGET_HARD_FLOAT
> + && warn_psabi
> + && use_fpr != 0
> + && has_cxx17_empty_base)
> + {
> + static unsigned last_reported_type_uid;
> + unsigned uid = TYPE_UID (TYPE_MAIN_VARIANT (valtype));
> + if (uid != last_reported_type_uid)
> + {
> + static const char *url
> + = CHANGES_ROOT_URL
> + "gcc-12/changes.html#mips_cxx17_empty_bases";
> + inform (input_location,
> + "the ABI for returning a value with C++ 17 empty "
Better write C++17 without space, that is what is used elsewhere too.
Ok with that change.
Jakub
next prev parent reply other threads:[~2022-04-06 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 12:33 [PATCH] " Xi Ruoyao
2022-04-06 12:44 ` Jakub Jelinek
2022-04-06 12:48 ` Xi Ruoyao
2022-04-06 13:44 ` [PATCH v2] " Xi Ruoyao
2022-04-06 14:34 ` Jakub Jelinek [this message]
2022-04-06 14:59 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2lBlEZQ5CDETob@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).