public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, msebor@redhat.com
Subject: Re: [PATCH] tree-optimization/105080 - make sure SCEV is available for ranger
Date: Mon, 28 Mar 2022 15:38:45 +0200	[thread overview]
Message-ID: <YkG6ZUaS6aYH6hdP@tucnak> (raw)
In-Reply-To: <2orq11q-7817-95q3-2p9r-s3q5958q1r@fhfr.qr>

On Mon, Mar 28, 2022 at 03:26:11PM +0200, Richard Biener wrote:
> On Mon, 28 Mar 2022, Jakub Jelinek wrote:
> 
> > On Mon, Mar 28, 2022 at 03:16:24PM +0200, Richard Biener wrote:
> > > When doing format diagnostics at -O0 we should make sure to make
> > > SCEV available to avoid false positives due to ranges we otherwise
> > > can trivially compute.
> > > 
> > > Bootstrap and regtest running on x86_64-unknown-linux-gnu.
> > > 
> > > OK if that succeeds?
> > 
> > Doesn't this slow down -O0 compilation too much?
> 
> Not if you do not enable the warning.  If you enable it you
> probably are set to pay for it.  Are you specifically
> concerned about the cases where SCEV / niter analysis take
> a lot of time or are you concerned about the constant overhead
> of enabling loops/SCEV?

I was just worried about the worst case compile time for -O0.
I think we already have tons of -fcompare-debug=-Wall (or -Wextra)
dependent code generation (mainly in the C++ FE) so until we are able to
deal with it making this -W* dependent isn't the end of the world.

Guess the patch is ok.  If we find bad compile time issues with it,
one way would be to enable it lazily (don't enable it initially,
when about to emit first warning instead enable it and retry).

	Jakub


      parent reply	other threads:[~2022-03-28 13:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 13:16 Richard Biener
2022-03-28 13:21 ` Jakub Jelinek
2022-03-28 13:26   ` Richard Biener
2022-03-28 13:29     ` Richard Biener
2022-03-28 13:38     ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkG6ZUaS6aYH6hdP@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=msebor@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).