From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id DEC3E3857C4A for ; Tue, 29 Mar 2022 15:34:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEC3E3857C4A Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22TF7bbP015378; Tue, 29 Mar 2022 15:34:34 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f3yfj06hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 15:34:34 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22TFTQKU000430; Tue, 29 Mar 2022 15:34:33 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01dal.us.ibm.com with ESMTP id 3f1tf9ttf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 15:34:33 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22TFYWwP40173976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Mar 2022 15:34:32 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 970AC28066; Tue, 29 Mar 2022 15:34:32 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4ABB728060; Tue, 29 Mar 2022 15:34:32 +0000 (GMT) Received: from li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com (unknown [9.160.115.34]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTPS; Tue, 29 Mar 2022 15:34:32 +0000 (GMT) Date: Tue, 29 Mar 2022 10:32:20 -0500 From: "Paul A. Clarke" To: Segher Boessenkool , gcc-patches@gcc.gnu.org Subject: Re: [PING^2 PATCH 2/3] rs6000: Move g++.dg powerpc PR tests to g++.target Message-ID: References: <20220221211747.53681-1-pc@us.ibm.com> <20220221211747.53681-3-pc@us.ibm.com> <20220223004145.GD614@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: s_V1zSHyPXsd2wg4XhmyTQVF46zgJiG8 X-Proofpoint-GUID: s_V1zSHyPXsd2wg4XhmyTQVF46zgJiG8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-29_06,2022-03-29_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203290092 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 15:34:37 -0000 Ping. On Tue, Mar 08, 2022 at 02:03:04PM -0600, Paul A. Clarke via Gcc-patches wrote: > Gentle ping. I am grateful for the initial review, but seek closure on the > final couple of discussion items. Thanks! > > PC > > On Tue, Feb 22, 2022 at 07:56:40PM -0600, Paul A. Clarke via Gcc-patches wrote: > > On Tue, Feb 22, 2022 at 06:41:45PM -0600, Segher Boessenkool wrote: > > > On Mon, Feb 21, 2022 at 03:17:46PM -0600, Paul A. Clarke wrote: > > > > Also adjust DejaGnu directives, as specifically requiring "powerpc*-*-*" is no > > > > longer required. > > > > > > > > 2021-02-21 Paul A. Clarke > > > > > > > > gcc/testsuite > > > > * g++.dg/pr65240.h: Move to g++.target/powerpc. > > > > * g++.dg/pr93974.C: Likewise. > > > > * g++.dg/pr65240-1.C: Move to g++.target/powerpc, adjust dg directives. > > > > * g++.dg/pr65240-2.C: Likewise. > > > > * g++.dg/pr65240-3.C: Likewise. > > > > * g++.dg/pr65240-4.C: Likewise. > > > > * g++.dg/pr65242.C: Likewise. > > > > * g++.dg/pr67211.C: Likewise. > > > > * g++.dg/pr69667.C: Likewise. > > > > * g++.dg/pr71294.C: Likewise. > > > > * g++.dg/pr84264.C: Likewise. > > > > * g++.dg/pr84279.C: Likewise. > > > > * g++.dg/pr85657.C: Likewise. > > > > > > Okay for trunk. Thanks! > > > > Thanks for the review! More below... > > > > > That said... > > > > > > > -/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */ > > > > -/* { dg-skip-if "" { powerpc*-*-darwin* } } */ > > > > +/* { dg-do compile { target lp64 } } */ > > > > +/* { dg-skip-if "" { *-*-darwin* } } */ > > > > > > That skip-if is most likely cargo cult, and it's not clear why lp64 > > > would be needed either (there is no comment what it is needed for, for > > > example). > > > > I can't speak to darwin, nor have an easy way of testing on it. > > > > As for lp64, these tests fail on -m32 with: > > cc1plus: error: '-mcmodel' not supported in this configuration > > - g++.dg/pr65240-1.C > > - g++.dg/pr65240-2.C > > - g++.dg/pr65240-3.C > > > > '-mcmodel' is in the dg-options line for the above tests. > > > > The rest PASSed. Shall I remove the 'lp64' restriction for those that PASS? > > > > > > +++ b/gcc/testsuite/g++.target/powerpc/pr85657.C > > > > @@ -1,4 +1,4 @@ > > > > -// { dg-do compile { target { powerpc*-*-linux* } } } > > > > +// { dg-do compile { target { *-*-linux* } } } > > > > > > A comment here would help as well. All of that is pre-existing of > > > course. > > > > I'm not sure what such a comment would say. I suspect it was a testing issue > > (only tested on Linux), but I have similar limitations, so I'm also reluctant > > to enable the test for what would be untested (by me) platforms. > > > > PC