From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0F73D3857C49 for ; Tue, 29 Mar 2022 17:26:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F73D3857C49 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22TEoTe8013554; Tue, 29 Mar 2022 17:26:23 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f3y8ttuqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 17:26:22 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22TGHjfe024331; Tue, 29 Mar 2022 17:26:22 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f3y8ttuq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 17:26:22 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22THJUmQ020074; Tue, 29 Mar 2022 17:26:21 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01dal.us.ibm.com with ESMTP id 3f1tf9ukp3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 17:26:20 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22THQJkW33095966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Mar 2022 17:26:19 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B308136053; Tue, 29 Mar 2022 17:26:19 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1207C13604F; Tue, 29 Mar 2022 17:26:19 +0000 (GMT) Received: from toto.the-meissners.org (unknown [9.65.244.27]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTPS; Tue, 29 Mar 2022 17:26:18 +0000 (GMT) Date: Tue, 29 Mar 2022 13:26:17 -0400 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner , Will Schmidt Subject: Re: [PATCH 4/4] Allow vsx_extract_ to use Altivec registers, PR target/99293 Message-ID: Mail-Followup-To: Michael Meissner , Segher Boessenkool , gcc-patches@gcc.gnu.org, David Edelsohn , Peter Bergner , Will Schmidt References: <20220328235914.GQ614@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328235914.GQ614@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: tF_Q7o_P0XYitA8zYrXE4DvT7wdMsuzW X-Proofpoint-ORIG-GUID: HzQ421osqwwA1XibDuygjxPtKAsS3Yy_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-29_07,2022-03-29_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203290097 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 17:26:25 -0000 On Mon, Mar 28, 2022 at 06:59:14PM -0500, Segher Boessenkool wrote: > On Mon, Mar 28, 2022 at 12:28:55PM -0400, Michael Meissner wrote: > > In looking at PR target/99293, I noticed that the vsx_extract_ > > pattern for V2DImode and V2DFmode only allowed traditional floating point > > registers, and it did not allow Altivec registers. The original code was > > written a few years ago when we used the old register allocator, and > > support for scalar floating point in Altivec registers was just being > > added to GCC. > > vsx_extract_ is from 2009... How time flies :-) > > This comment is from 2016 though. Still before LRA was default for us > of course ;-) The support for scalars in Altivec registers wasn't really done until the 2016 time frame. At the time I had tried to use VSX registers for this, but I could never get a reproducable case for the failure other one spec benchmark not building with some flags (most likely spec 2017's 521.wrf_r or spec 2006's 481.wrf). So I opted to just keep it limited to traditional FPR registers, and maybe fix it some time later. > If would have been nice if we had a testcase for this breakage, so that > we could now be confident it really has been fixed. But the "reload" > here likely means "old reload", so okay. Yes, it was the old reload. > > PR target/99293 > > It has essentially nothing to do with that PR, right? Or I just do not > see it, always a possibility of course. It was just that I noticed the change in looking at PR target/99293. I did remove the reference from the checkin commit. > > * config/rs6000/rs6000.md (vsx_extract_): Allow destination > > to be an Altivec register. > > ... to be any VSX register. Thanks. > Okay for trunk with those things fixed. Thanks! Done. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com