From: Jakub Jelinek <jakub@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>,
dje@gmail.com, bill.schmidt@fastmail.com,
gcc-patches@gcc.gnu.org
Subject: rs6000 patch ping^2: [PATCH 8/8] rs6000: Fix some missing built-in attributes [PR104004]
Date: Wed, 30 Mar 2022 14:28:20 +0200 [thread overview]
Message-ID: <YkRM5EOm6guXDJID@tucnak> (raw)
In-Reply-To: <YjCSCO8oUurdOcCm@tucnak>
On Tue, Mar 15, 2022 at 02:18:00PM +0100, Jakub Jelinek via Gcc-patches wrote:
> On Fri, Jan 28, 2022 at 11:50:26AM -0600, Bill Schmidt via Gcc-patches wrote:
> > PR104004 caught some misses on my part in converting to the new built-in
> > function infrastructure. In particular, I forgot to mark all of the "nosoft"
> > built-ins, and one of those should also have been marked "no32bit".
> >
> > Bootstrapped and tested on powerpc64le-linux-gnu with no regressions.
> > Is this okay for trunk?
> >
> > Thanks,
> > Bill
> >
> >
> > 2022-01-27 Bill Schmidt <wschmidt@linux.ibm.com>
> >
> > gcc/
> > * config/rs6000/rs6000-builtin.def (MFFSL): Mark nosoft.
> > (MTFSB0): Likewise.
> > (MTFSB1): Likewise.
> > (SET_FPSCR_RN): Likewise.
> > (SET_FPSCR_DRN): Mark nosoft and no32bit.
>
> This patch fixes a P1 regression and from my (limited) understanding
> doesn't depend on any other patch in the series.
>
> Is this ok for trunk (I agree some testcase coverage would be nice)?
I'd like to ping this again.
> > diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def
> > index c8f0cf332eb..98619a649e3 100644
> > --- a/gcc/config/rs6000/rs6000-builtins.def
> > +++ b/gcc/config/rs6000/rs6000-builtins.def
> > @@ -215,7 +215,7 @@
> > ; processors, this builtin automatically falls back to mffs on older
> > ; platforms. Thus it appears here in the [always] stanza.
> > double __builtin_mffsl ();
> > - MFFSL rs6000_mffsl {}
> > + MFFSL rs6000_mffsl {nosoft}
> >
> > ; This is redundant with __builtin_pack_ibm128, as it requires long
> > ; double to be __ibm128. Should probably be deprecated.
> > @@ -226,10 +226,10 @@
> > MFTB rs6000_mftb_di {32bit}
> >
> > void __builtin_mtfsb0 (const int<0,31>);
> > - MTFSB0 rs6000_mtfsb0 {}
> > + MTFSB0 rs6000_mtfsb0 {nosoft}
> >
> > void __builtin_mtfsb1 (const int<0,31>);
> > - MTFSB1 rs6000_mtfsb1 {}
> > + MTFSB1 rs6000_mtfsb1 {nosoft}
> >
> > void __builtin_mtfsf (const int<0,255>, double);
> > MTFSF rs6000_mtfsf {}
> > @@ -238,7 +238,7 @@
> > PACK_IF packif {}
> >
> > void __builtin_set_fpscr_rn (const int[0,3]);
> > - SET_FPSCR_RN rs6000_set_fpscr_rn {}
> > + SET_FPSCR_RN rs6000_set_fpscr_rn {nosoft}
> >
> > const double __builtin_unpack_ibm128 (__ibm128, const int<0,1>);
> > UNPACK_IF unpackif {}
> > @@ -2969,7 +2969,7 @@
> > PACK_TD packtd {}
> >
> > void __builtin_set_fpscr_drn (const int[0,7]);
> > - SET_FPSCR_DRN rs6000_set_fpscr_drn {}
> > + SET_FPSCR_DRN rs6000_set_fpscr_drn {nosoft,no32bit}
> >
> > const unsigned long long __builtin_unpack_dec128 (_Decimal128, \
> > const int<0,1>);
> > --
> > 2.27.0
>
> Jakub
Jakub
next prev parent reply other threads:[~2022-03-30 12:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 17:50 [PATCH 0/8] rs6000: Built-in function cleanups and bug fixes Bill Schmidt
2022-01-28 17:50 ` [PATCH 1/8] rs6000: More factoring of overload processing Bill Schmidt
2022-01-28 19:11 ` Segher Boessenkool
2022-01-28 21:19 ` Bill Schmidt
2022-01-28 23:09 ` Segher Boessenkool
2022-02-01 14:49 ` [PATCH v2 " Bill Schmidt
2022-02-01 21:48 ` Segher Boessenkool
2022-02-02 18:46 ` Bill Schmidt
2022-02-03 14:44 ` [PATCH v3 " Bill Schmidt
2022-02-04 1:24 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 2/8] rs6000: Don't #ifdef "short" built-in names Bill Schmidt
2022-01-28 20:32 ` Segher Boessenkool
2022-01-28 21:21 ` Bill Schmidt
2022-01-28 17:50 ` [PATCH 3/8] rs6000: Convert <x> built-in constraints to <x,y> form Bill Schmidt
2022-01-28 23:24 ` [PATCH 3/8] rs6000: Convert <x> built-in constraints to <x, y> form Segher Boessenkool
2022-01-31 17:21 ` [PATCH 3/8] rs6000: Convert <x> built-in constraints to <x,y> form Bill Schmidt
2022-01-31 17:28 ` [PATCH 3/8] rs6000: Convert <x> built-in constraints to <x, y> form Segher Boessenkool
2022-01-31 17:31 ` [PATCH 3/8] rs6000: Convert <x> built-in constraints to <x,y> form Bill Schmidt
2022-02-01 14:53 ` [PATCH v2 3/8] rs6000: Unify error messages for built-in constant restrictions Bill Schmidt
2022-02-01 22:16 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 4/8] rs6000: Consolidate target built-ins code Bill Schmidt
2022-01-31 21:32 ` Segher Boessenkool
2022-01-31 22:01 ` Bill Schmidt
2022-01-31 22:33 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 5/8] rs6000: Fix LE code gen for vec_cnt[lt]z_lsbb [PR95082] Bill Schmidt
2022-02-01 23:01 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 6/8] rs6000: Remove -m[no-]fold-gimple flag [PR103686] Bill Schmidt
2022-02-02 23:21 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 7/8] rs6000: vec_neg built-ins wrongly require POWER8 Bill Schmidt
2022-02-07 15:48 ` Bill Schmidt
2022-03-30 18:04 ` Segher Boessenkool
2022-01-28 17:50 ` [PATCH 8/8] rs6000: Fix some missing built-in attributes [PR104004] Bill Schmidt
2022-03-15 13:18 ` rs6000 patch ping: " Jakub Jelinek
2022-03-30 12:28 ` Jakub Jelinek [this message]
2022-03-30 23:07 ` Segher Boessenkool
2022-03-31 22:17 ` Segher Boessenkool
2022-03-30 17:41 ` will schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkRM5EOm6guXDJID@tucnak \
--to=jakub@redhat.com \
--cc=bill.schmidt@fastmail.com \
--cc=dje@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).