From: Jakub Jelinek <jakub@redhat.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>,
YunQiang Su <yunqiang.su@cipunited.com>
Subject: Re: [PATCH v2] mips: Emit psabi diagnostic for return values affected by C++ zero-width bit-field ABI change [PR 102024]
Date: Fri, 1 Apr 2022 13:41:24 +0200 [thread overview]
Message-ID: <Ykbk5LK2/uXo+zpy@tucnak> (raw)
In-Reply-To: <36d825b98e0f18f6fff182473c3a4fff4809f722.camel@mengyan1223.wang>
On Fri, Apr 01, 2022 at 07:38:59PM +0800, Xi Ruoyao wrote:
> v1 -> v2:
>
> * "int has_zero_width_bf" -> "bool has_cxx_zero_width_bf". "int" to
> "bool" because the value is 0/1 only. Add "cxx" because it only
> indicates C++ zero-width bit-fields (not those bit-fields from C).
>
> * Coding style fix.
>
> * Rewrite mips_return_in_msb so mips_fpr_return_fields is not called
> unnecessarily.
>
> * "retcon" -> "change".
>
> gcc/
> PR target/102024
> * mips.cc (mips_fpr_return_fields): Detect C++ zero-width
> bit-fields and set up an indicator.
> (mips_return_in_msb): Adapt for mips_fpr_return_fields change.
> (mips_function_value_1): Diagnose when the presense of a C++
> zero-width bit-field changes function returning in GCC 12.
>
> gcc/testsuite/
> PR target/102024
> * g++.target/mips/mips.exp: New test supporting file.
> * g++.target/mips/pr102024-1.C: New test.
LGTM, thanks.
Jakub
prev parent reply other threads:[~2022-04-01 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:13 [PATCH] " Xi Ruoyao
2022-03-31 17:04 ` Jakub Jelinek
2022-04-01 11:38 ` [PATCH v2] " Xi Ruoyao
2022-04-01 11:41 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykbk5LK2/uXo+zpy@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).