From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C146B3858D28 for ; Fri, 1 Apr 2022 11:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C146B3858D28 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-zqw1ltnhOR-J-o7NUfDrYQ-1; Fri, 01 Apr 2022 07:41:30 -0400 X-MC-Unique: zqw1ltnhOR-J-o7NUfDrYQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE08F3820548; Fri, 1 Apr 2022 11:41:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.220]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 875B95E2577; Fri, 1 Apr 2022 11:41:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 231BfQ49005037 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 1 Apr 2022 13:41:27 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 231BfOur005036; Fri, 1 Apr 2022 13:41:24 +0200 Date: Fri, 1 Apr 2022 13:41:24 +0200 From: Jakub Jelinek To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek , Richard Sandiford , YunQiang Su Subject: Re: [PATCH v2] mips: Emit psabi diagnostic for return values affected by C++ zero-width bit-field ABI change [PR 102024] Message-ID: Reply-To: Jakub Jelinek References: <03bbbd29325ec7f76809ef63ef8f92f930442a18.camel@mengyan1223.wang> <36d825b98e0f18f6fff182473c3a4fff4809f722.camel@mengyan1223.wang> MIME-Version: 1.0 In-Reply-To: <36d825b98e0f18f6fff182473c3a4fff4809f722.camel@mengyan1223.wang> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 11:41:34 -0000 On Fri, Apr 01, 2022 at 07:38:59PM +0800, Xi Ruoyao wrote: > v1 -> v2: > > * "int has_zero_width_bf" -> "bool has_cxx_zero_width_bf". "int" to > "bool" because the value is 0/1 only. Add "cxx" because it only > indicates C++ zero-width bit-fields (not those bit-fields from C). > > * Coding style fix. > > * Rewrite mips_return_in_msb so mips_fpr_return_fields is not called > unnecessarily. > > * "retcon" -> "change". > > gcc/ > PR target/102024 > * mips.cc (mips_fpr_return_fields): Detect C++ zero-width > bit-fields and set up an indicator. > (mips_return_in_msb): Adapt for mips_fpr_return_fields change. > (mips_function_value_1): Diagnose when the presense of a C++ > zero-width bit-field changes function returning in GCC 12. > > gcc/testsuite/ > PR target/102024 > * g++.target/mips/mips.exp: New test supporting file. > * g++.target/mips/pr102024-1.C: New test. LGTM, thanks. Jakub