From: Jakub Jelinek <jakub@redhat.com>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: gcc-patches@gcc.gnu.org,
Richard Sandiford <richard.sandiford@arm.com>,
Jakub Jelinek <jakub@gcc.gnu.org>,
YunQiang Su <yunqiang.su@cipunited.com>
Subject: Re: [PATCH v2] Ignore zero width fields in arguments and issue -Wpsabi warning about C zero-width field ABI changes [PR102024]
Date: Fri, 1 Apr 2022 14:38:36 +0200 [thread overview]
Message-ID: <YkbyTCGMMYidzGS7@tucnak> (raw)
In-Reply-To: <a482297b4f7b135f1d338fa20ec5e7c17d89ba70.camel@mengyan1223.wang>
On Fri, Apr 01, 2022 at 08:11:43PM +0800, Xi Ruoyao wrote:
> v1 -> v2:
>
> * "int has_zero_width_bf_abi_change" -> "bool
> zero_width_field_abi_change". "int" -> "bool" because it's only 0/1,
> "bf" -> "field" because the change also affects zero-length arrays and
> empty structs/unions, etc.
>
> * Add tests with zero-length array and empty struct.
>
> * Coding style fix.
>
> * "#zero_width_bitfields" -> "#mips_zero_width_fields" because this is
> not the exactly same change documented by #zero_width_bitfields. I'll
> send a wwwdoc patch after this is approved.
>
> gcc/
> PR target/102024
> * mips.cc (mips_function_arg): Ignore zero-width fields, and
> inform if it causes a psABI change.
>
> gcc/testsuite/
> PR target/102024
> * gcc.target/mips/pr102024-1.c: New test.
> * gcc.target/mips/pr102024-2.c: New test.
> * gcc.target/mips/pr102024-3.c: New test.
LGTM, thanks.
Jakub
prev parent reply other threads:[~2022-04-01 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 16:27 [PATCH] mips: Ignore zero width bitfields in arguments and issue -Wpsabi warning about C zero-width bit-field " Xi Ruoyao
2022-03-31 16:47 ` Jakub Jelinek
2022-04-01 12:11 ` [PATCH v2] Ignore zero width fields in arguments and issue -Wpsabi warning about C zero-width field " Xi Ruoyao
2022-04-01 12:38 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkbyTCGMMYidzGS7@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).