From: Jan Hubicka <hubicka@kam.mff.cuni.cz>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] cgraph: Fix up semantic_interposition handling [PR105306]
Date: Wed, 20 Apr 2022 11:18:07 +0200 [thread overview]
Message-ID: <Yl/Pz3cawUVVlLap@kam.mff.cuni.cz> (raw)
In-Reply-To: <Yl/OqZz9gzov5AI8@tucnak>
>
> The cgraph.cc change was what I actually needed for the fix, the
> cgraphclones.cc was only because I've noticed that it constructs a new
> node (so is initialized to whatever random flag_semantic_interposition is
> right now) and initializing it to what it is cloned from made more sense.
OK, thanks.
It only is needed for nodes which definition flag and public linkage, so
should not need to copy in cgraph clones and there are other places that
creates new nodes (late function etc). I will move the logic to
visibility pass and to add_new_function and also kill the constructor.
I originally intended to set it at the consturction time but forget to
think of the frotnends changing opt_for_fn later from the optimization
attribute. This also makes me wonder if C++ FE updates the implicit
aliases once they have been created...
Honza
>
> Jakub
>
next prev parent reply other threads:[~2022-04-20 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 6:23 Jakub Jelinek
2022-04-20 7:19 ` Richard Biener
2022-04-20 8:45 ` Jan Hubicka
2022-04-20 8:56 ` Jakub Jelinek
2022-04-20 9:06 ` Jan Hubicka
2022-04-20 9:13 ` Jakub Jelinek
2022-04-20 9:18 ` Jan Hubicka [this message]
2022-04-20 11:47 ` Martin Jambor
2022-04-20 11:54 ` Jakub Jelinek
2022-04-20 11:59 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl/Pz3cawUVVlLap@kam.mff.cuni.cz \
--to=hubicka@kam.mff.cuni.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).